Should lookups be split out or otherwise disabled by default?

2022-01-13 Thread Matt Sicker
For the extra paranoid users and users who already use some other method of generating config files (e.g., using the ConfigurationBuilder DSL which already supports arbitrary Java code), it seems like a useful feature to make lookups an opt-in feature. What do you all think? Any splitting from c

Re: Maven published jars not matching jars downloaded from apache.org?

2022-01-13 Thread Matt Sicker
I don't think we've upgraded the parent pom yet, so we still didn't have reproducible builds enabled at that time. On Thu, Jan 13, 2022 at 2:59 AM Jason Pyeron wrote: > > > -Original Message- > > From: Matt Sicker > > Sent: Wednesday, December 29, 2021 1:33 PM > > > > This is something th

Re: Code Formatter?

2022-01-13 Thread Matt Sicker
I'd love for a formatter to be added. I'm not sure how we could best approach reformatting (all at once or incrementally). What I've liked in the Spinnaker project is that we use spotless and a git pre-commit hook to help ensure everyone's code gets formatted appropriately before being committed.

Re: Code Formatter?

2022-01-13 Thread Xeno Amess
and it uses eclipse formatter to file, so I do think you can export&import Eclipse config file Xeno Amess 于2022年1月13日周四 17:54写道: > try this: > > net.revelc.code.formatter:formatter-maven-plugin:2.17.1 > > It worked well in my team for 2 years, never cause any trouble. > > Gary Gregory 于2022年1月1

Re: Code Formatter?

2022-01-13 Thread Xeno Amess
try this: net.revelc.code.formatter:formatter-maven-plugin:2.17.1 It worked well in my team for 2 years, never cause any trouble. Gary Gregory 于2022年1月13日周四 17:36写道: > I am ok with formatting code but I want to do it in Eclipse. I did not even > notice the POM was changed. I would think it bet

Re: Code Formatter?

2022-01-13 Thread Gary Gregory
I am ok with formatting code but I want to do it in Eclipse. I did not even notice the POM was changed. I would think it better (for me at least) if an Eclipse config file was provided I can just import, then when I format the code for a method/class/package, the same formatting applies (as whateve

RE: Maven published jars not matching jars downloaded from apache.org?

2022-01-13 Thread Jason Pyeron
> -Original Message- > From: Matt Sicker > Sent: Wednesday, December 29, 2021 1:33 PM > > This is something that has been fixed (or will be fixed) in recent versions. > This was caused by one of > the Maven plugins in use outputting the current timestamp when it was run > into the manife

Re: Code Formatter?

2022-01-13 Thread Jochen Wiedmann
On Thu, Jan 13, 2022 at 4:23 AM Carter Kozak wrote: > We've discussed the idea of using a code formatter before, I finally had a > moment put up an example. Please take a look and provide feedback at your > convenience :-) > https://github.com/apache/logging-log4j2/pull/697 The main problem, t