Re: maven-shaded-log4j-transformer

2021-10-18 Thread Volkan Yazıcı
Makes sense Eduardo, go ahead with your proposal for the first draft. On Mon, Oct 18, 2021 at 7:22 PM Eduard Gizatullin wrote: > Hello Volkan, > > Thanks for your explanation, I really appreciate it and I think I can make > a pull request tomorrow. > > With hindsight, couldn't you please conside

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
OK. So you are proposing that instead of documenting the plugin in the Log4j web site that we create a new site for it using GitHub Pages? Ralph > On Oct 18, 2021, at 12:45 PM, Matt Sicker wrote: > > The Maven shade plugin thing. > > On Mon, Oct 18, 2021 at 2:44 PM Apache wrote: >> >> What

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
The Maven shade plugin thing. On Mon, Oct 18, 2021 at 2:44 PM Apache wrote: > > What new plug-in? > > Ralph > > > On Oct 18, 2021, at 12:32 PM, Matt Sicker wrote: > > > > Testing the website publishing from the new plugin. It’s probably easier > > to keep it under the ASF pages thing than it i

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Apache
What new plug-in? Ralph > On Oct 18, 2021, at 12:32 PM, Matt Sicker wrote: > > Testing the website publishing from the new plugin. It’s probably easier to > keep it under the ASF pages thing than it is to combine it with GH pages. > Since it’s storing generated markup in a git repo, it doesn

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
Testing the website publishing from the new plugin. It’s probably easier to keep it under the ASF pages thing than it is to combine it with GH pages. Since it’s storing generated markup in a git repo, it doesn’t matter much which system it’s using besides whatever integration we already have set

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
I feel like I am going in circles. Testing of what? I still don’t understand what the use case is for GitHub Pages. What problem is it solving? Ralph > On Oct 18, 2021, at 12:05 PM, Matt Sicker wrote: > > I’d imagine it’s for testing purposes initially. We should integrate it into > the main

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
I’d imagine it’s for testing purposes initially. We should integrate it into the main domain when it’s ready for release. This should all be controllable via the .asf.yaml file. Matt Sicker > On Oct 18, 2021, at 12:32, Ralph Goers wrote: > > Why? > > Ralph > >> On Oct 18, 2021, at 8:40 AM,

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Ralph Goers
I agree with both of your points. Ralph > On Oct 18, 2021, at 10:14 AM, Eduard Gizatullin wrote: > > Hello Volkan, > > Thanks for your explanation, I really appreciate it and I think I can make > a pull request tomorrow. > > With hindsight, couldn't you please consider below points: > > 1. m

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
Why? Ralph > On Oct 18, 2021, at 8:40 AM, Volkan Yazıcı wrote: > > For the moment, I just want the `gh-pages` branch of the logging-log4j2 > GitHub project to be accessible at "a" URL – just like any other non-ASF > GitHub project. > > On Mon, Oct 18, 2021 at 5:38 PM Ralph Goers > wrote: > >

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Eduard Gizatullin
Hello Volkan, Thanks for your explanation, I really appreciate it and I think I can make a pull request tomorrow. With hindsight, couldn't you please consider below points: 1. maven-shaded-log4j-transformer is not a plugin, it's an extension for the existing shaded plugin. Also the dependency mu

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Volkan Yazıcı
For the moment, I just want the `gh-pages` branch of the logging-log4j2 GitHub project to be accessible at "a" URL – just like any other non-ASF GitHub project. On Mon, Oct 18, 2021 at 5:38 PM Ralph Goers wrote: > OK. That page didn’t exist when I migrated the site from the CMS. That > still lea

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Volkan Yazıcı
Okay, I am not strongly opinionated about this. Let's have the initial PR first without creating too much confusion for Eduard. We can continue the artifact ID debate there, if needed. After all, it is a directory rename and 2 lines of `pom.xml` changes. On Mon, Oct 18, 2021 at 5:33 PM Ralph Goers

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
OK. That page didn’t exist when I migrated the site from the CMS. That still leaves the second question. What are you proposing? I don’t really see the point of moving the existing site to GitHub Pages. Ralph > On Oct 18, 2021, at 8:31 AM, Volkan Yazıcı wrote: > > GitHub Pages look pretty d

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Volkan Yazıcı
Matt, okay, forget about the domain name. Can you help me with setting up gh-pages branch to show up in a page that is not overriding a currently existing one. Any domain name is fine. On Fri, Oct 15, 2021 at 5:27 PM Matt Sicker wrote: > I’m not exactly sure how we can get a beta subdomain, thou

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Ralph Goers
While I am in favor of short names this might be too short. Having a single Maven plugin that does various different things isn’t the norm. I would suggest the name either be log4j-maven-shade-plugin or log4j-maven-transformer-plugin. Ralph > On Oct 18, 2021, at 8:22 AM, Volkan Yazıcı wrote: >

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Volkan Yazıcı
GitHub Pages look pretty doable to me: https://cwiki.apache.org/confluence/display/INFRA/GitHub+Pages On Fri, Oct 15, 2021 at 6:35 PM Ralph Goers wrote: > I don’t really understand this. When I was migrating the web site from the > ASF CMS to GitHub > it was made clear that web site hosting usin

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Volkan Yazıcı
Hello Eduard, Let me wrap up the feedback so far: *Project Repository:* https://github.com/apache/logging-log4j-tools *Module group ID:* org.apache.logging.maven *Module artifact ID:* log4j-maven-plugin[1] *Transformer class name:* Log4j2PluginCacheFileTransformer [1] I am in favor of keeping th