Re: Continuous performance test bed using GitHub Actions

2021-10-13 Thread Matt Sicker
That's really cool! Do note that we can publish to the ASF-specific branches, too, for hosting a site. On Wed, Oct 13, 2021 at 10:37 AM Volkan Yazıcı wrote: > > Do this: > > git fetch -p > git checkout -B gh-pages origin/gh-pages > python -m http.server > open http://localhost:8000/benchmark/resu

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Matt Sicker
The 3.x code loads plugins from generated Java classes that correspond to ServiceLoader-loadable classes. Since each jar tends to end up with their generated plugin class going into different package names, the result of shading them together works naturally with combining the META-INF/services/ fi

Continuous performance test bed using GitHub Actions

2021-10-13 Thread Volkan Yazıcı
Do this: git fetch -p git checkout -B gh-pages origin/gh-pages python -m http.server open http://localhost:8000/benchmark/results/index.html *The magic:* https://github.com/apache/logging-log4j2/blob/release-2.x/.github/workflows/benchmark.yml *Disadvantages:* Runner specs are on the flux, thoug

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Volkan Yazıcı
It works on `master`. Matt, mind shedding some light on why it works on `master`, but doesn't on `release-2.x`? Maybe we can backport the trick on `master` to `release-2.x`? On Wed, Oct 13, 2021 at 4:05 PM Apache wrote: > We could include it in Log4J. Does master work out of the box? > > Ralph >

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Apache
We could include it in Log4J. Does master work out of the box? Ralph > On Oct 13, 2021, at 12:23 AM, Volkan Yazıcı wrote: > >  > I have done something really nasty in the release-2.x branch to fix > benchmarks.jar generated by log4j-perf. Since a picture is worth a thousand > words, I am sha

broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Volkan Yazıcı
I have done something really nasty in the release-2.x branch to fix benchmarks.jar generated by log4j-perf. Since a picture is worth a thousand words, I am sharing two: [image: image.png] [image: image.png] (In case images get truncated, see commit 4049240c.) In a nutshell, Log4j2Plugins.dat of t