Re: JsonTemplateLayout for Google Cloud Logging

2021-07-05 Thread Raman Gupta
On Sun, Jul 4, 2021 at 2:59 PM Volkan Yazıcı wrote: > *[My answers are inline.]* > > On Thu, Jul 1, 2021 at 11:48 PM Raman Gupta wrote: > > > > > https://issues.apache.org/jira/browse/LOG4J2-3116 > > https://github.com/apache/logging-log4j2/pull/543 > > > > Thanks! I will check these out momenta

Re: Rolling tests / writing X log messages per second

2021-07-05 Thread Robert Middleton
That does sound like a good idea. We can probably replace all of the calls to APR for the time with their C++ standard equivalents as well to allow for easy mocking. -Robert Middleton On Mon, Jul 5, 2021 at 3:26 AM Volkan Yazıcı wrote: > I totally agree with Matt on this. Once the code starts

Re: Rolling tests / writing X log messages per second

2021-07-05 Thread Volkan Yazıcı
I totally agree with Matt on this. Once the code starts changing behaviour via the system time, it becomes practically impossible to decently test it. If you can mock the clock, testing becomes tractable. To the best of my knowledge, that is what we mostly do in Log4j too. On Sun, Jul 4, 2021 at 8