Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
While you could write the ServiceLoader class by hand, I wouldn’t want anyone to. That would be error prone. I have though about creating a Maven plugin to generate the class, but all that would do is replace the proc=only compile step, so there isn’t much point. Ralph > On May 29, 2021, at 5

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Matt Sicker
I'm having some fun right now figuring out the proper module openings to enable for Java 16, so yes, I agree that the module system has been a pain in the ass. I do like the idea of ensuring the output of the annotation processor is a simple service loader class that could be written by hand if nee

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
We do need better docs on this. 3.0 is going to be a mixed bag. It will be easier for “normal” applications because plugins now use ServiceLoader instead of the Log4jPlugins.dat file. However, it is going to be more challenging for those developing plugins if they use the Java Platform Module

[LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Matt Sicker
Hey all, that itch is back to figure out how to complete my previous attempt at the plugin system updates (started a little over a year ago and put on pause at some point). I'm currently working on getting that branch back up to working again with master (mostly needing to update module-info files)

[LOG4J2-3100] log4j2 lots of final class, forbid extend class, why log4j allow extend class but log4j2 not?

2021-05-29 Thread Volkan Yazıcı
I have shared my personal take on this issue in the ticket. Please comment on the ticket if you have any other remarks. On Sat, May 29, 2021 at 1:17 PM Volkan Yazici (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/LOG4J2-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:c