Re: Fix windows build on master (via Tim Perry)

2021-05-03 Thread Tim Perry
After more carefully reading the code and unit tests, I have come to the conclusion that the interaction between context-specific listeners and the StatusLogger lifecycle need to be rethought. My approach, at best, would have arrived at a kludge that worked but made the code difficult to maintain.

Re: [LOG4CXX] Release log4cxx 0.12.0-RC2

2021-05-03 Thread Robert Middleton
I honestly don't know how important these warnings are - I don't do much on Windows. As far as I'm aware the declspec should be #defined correctly, could that have something to do with it? -Robert Middleton On Mon, May 3, 2021 at 2:20 PM Patrick Mills wrote: > > Anyone else building DLLs in Win

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
I don’t understand. The TimeFilter filters totally based on time. We would need to create a new TimeThresholdFilter. Ralph > On May 3, 2021, at 10:45 AM, Gary Gregory wrote: > > You're talking about a custom class? What about adding a defaultThreshold > to TimeFilter? Would that be reasonable?

Re: Log levels on a schedule

2021-05-03 Thread Gary Gregory
You're talking about a custom class? What about adding a defaultThreshold to TimeFilter? Would that be reasonable? Gary On Mon, May 3, 2021, 10:12 Apache wrote: > That would be exactly right. I would create a TimeFilter that is very much > like the DynamicThresholdFilter but instead of using a

[LOG4CXX] Release log4cxx 0.12.0-RC2

2021-05-03 Thread Patrick Mills
Anyone else building DLLs in Windows environment? I'm seeing lots of warnings in VS 2019. Wondering if these should be disabled or a note added about ignoring them. Or perhaps I'm doing something wrong in my cmake build: cmake -DCMAKE_GENERATOR_PLATFORM=x64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INS

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
Almost, but not quite. It looks like the TimeFilter will completely disable logging during the interval. Ralph > On May 3, 2021, at 7:50 AM, Matt Sicker wrote: > > Might be able to use a time filter? > http://logging.apache.org/log4j/2.x/manual/filters.html#TimeFilter > > On Mon, May 3, 2021

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-03 Thread Matt Sicker
If you don't feel the NOTICE file is a problem, then please make sure to update it in git for the next release. :) Signatures checked out, source archives look good. +1 On Mon, 3 May 2021 at 10:54, Thorsten Schöning wrote: > > Guten Tag Robert Middleton, > am Samstag, 1. Mai 2021 um 23:07 schrie

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-03 Thread Thorsten Schöning
Guten Tag Robert Middleton, am Samstag, 1. Mai 2021 um 23:07 schrieben Sie: > Please download, test, and cast your votes on the log4j developers list. +1 The wrong NOTICE can be fixed later in my opinion, it has been wrong for multiple releases already. Mit freundlichen Grüßen Thorsten Schönin

Re: Log levels on a schedule

2021-05-03 Thread Matt Sicker
Might be able to use a time filter? http://logging.apache.org/log4j/2.x/manual/filters.html#TimeFilter On Mon, May 3, 2021 at 09:12 Apache wrote: > That would be exactly right. I would create a TimeFilter that is very much > like the DynamicThresholdFilter but instead of using an MDC key it woul

Re: Log levels on a schedule

2021-05-03 Thread Apache
That would be exactly right. I would create a TimeFilter that is very much like the DynamicThresholdFilter but instead of using an MDC key it woul use a time frame. This would be interesting as it could be implemented to either check the time in the event for every request or it could create a

Log levels on a schedule

2021-05-03 Thread Gary Gregory
I just had an interesting request: Debug logging produces a ton of output and what is being debugged only happens in a specific time window. How can we configure debug logging to enable in a time window...? Any thoughts on this? Can a TimeFilter be configured to only filter debug events? Gary