Re: [log4cxx] Release Prep

2021-04-14 Thread Robert Middleton
Also, question for Thorsten: are you comfortable closing PR #22 at this point? There's been no activity on it for a year at this point, and it seems like the resolution we came up with was "don't do anything". -Robert Middleton On Wed, Apr 14, 2021 at 9:27 PM Robert Middleton wrote: > > > Using

Re: [log4cxx] Release Prep

2021-04-14 Thread Robert Middleton
> Using ${CMAKE_SOURCE_DIR} instead of a relative path creates a problem > when including the log4cxx root directory from a higher level > CMakeLists.txt. CMAKE_SOURCE_DIR is (inconveniently) set where the top-most > CMakeLists.txt file resides. > > You are using ${CMAKE_SOURCE_DIR} in src/main