Re: Please do not commit to log4j2 master - but review this PR.

2021-04-08 Thread Ralph Goers
To to that would require 2 test modules. The first would generate the test classes that are used by both the unit tests and downstream modules. The second would be the unit tests themselves. However, I have doubts that that would work. As I said, Maven allows an essentially illegal module-info.

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-08 Thread Volkan Yazıcı
> Note that all of this occurs ONLY because we are creating a test jar that will be used by other modules. If it would simplify the build setup, why don't we migrate test-jars to their individual Maven modules? For instance, log4j-core and log4j-core-test, etc. On Tue, Apr 6, 2021 at 5:11 AM Ralp

Review Request: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-08 Thread Volkan Yazıcı
*JIRA ticket:* https://issues.apache.org/jira/browse/LOG4J2-3056 *GitHub pull request:* https://github.com/apache/logging-log4j2/pull/484

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-08 Thread Volkan Yazıcı
I have also tried that too, but no luck so far. @Matt, are you able to run any tests from IDEA using the most recent "master"? On Wed, Apr 7, 2021 at 5:57 PM Matt Sicker wrote: > See also > https://lists.apache.org/thread.html/2ba2225043a6ca7d2c43e4293323309b041bd8d486516cc50fec61cd%40%3Cdev.log

Re: Garbage Free Precise Time

2021-04-08 Thread Ralph Goers
I spoke too soon. It didn’t really pass on Java 16. The allocation instrumenter was unable to instrument anything so it didn’t generate the errors the test looks for. I tried with Java 12-14 and those all failed. In Java 15 the JVM crashed. Ralph > On Apr 7, 2021, at 11:36 PM, Ralph Goers wr