I took care of the failure on verify. I added a clean to log4j-api so it will
clean every time.
Ralph
> On Apr 5, 2021, at 10:55 PM, Ralph Goers wrote:
>
> Matt,
>
> A couple of comments
> This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn
> command. This will modify
Matt,
A couple of comments
This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn
command. This will modify them to use Java 11 instead of Java 8. Did we really
want to do that?
The Jenkins build is still failing. The first phase that compiles works but the
second phase that
OK, release-2.x now seems to be better but I don’t understand what is going on
with Master. I am sure I built master several times over the weekend. But now
it is getting errors all over the place in Json Template Layout tests. I did
two commits that shouldn’t have impacted anything in that.
My
Nothing in Commons requires more than Java 8. JPMS support is done as one
offs here and there with automatic module names.
I don't see it getting better and really supporting JPMS until a component
requires Java 11, the next LTS version after 8. That might not be for a
while... IBM does not suppor
> On Apr 5, 2021, at 1:31 PM, Volkan Yazıcı wrote:
>
>> ... this weird structure with two test source directories ...
>
> doesn't seem okay to me. Please, don't get me wrong. Not that I know of
> JPMS or anything, though this sttructure doesn't resemble anything I have
> ever seen. I don't wan
The Windows build doesn't seem to be the issue. It seems to be related
to running mvn deploy for the snapshot. See logs:
https://ci-builds.apache.org/job/Logging/job/log4j/job/master/256/console
On Mon, 5 Apr 2021 at 16:34, Matt Sicker wrote:
>
> Alright, the Linux side passed, but the Windows si
TypeConverterRegistry updates should be fine, just note I had to
structure some of the code as it is as it can't rely on much else
being set up quite yet. Even with the DI-rewrite, I think this area
would still have limited ability to inject any configuration state as
it's used for parsing and inje
Alright, the Linux side passed, but the Windows side had a
module-related import error with OSGi.
On Mon, 5 Apr 2021 at 16:21, Matt Sicker wrote:
>
> I've updated the mvn step to use Java 11 on the master branch. That
> will apply to any other pipelines using this at the moment, but that
> should
I've updated the mvn step to use Java 11 on the master branch. That
will apply to any other pipelines using this at the moment, but that
shouldn't be a problem for now.
On Mon, 5 Apr 2021 at 09:30, Matt Sicker wrote:
>
> Also, Jenkins docs are usually in Jenkins itself like these useful
> pages (
> ... this weird structure with two test source directories ...
doesn't seem okay to me. Please, don't get me wrong. Not that I know of
JPMS or anything, though this sttructure doesn't resemble anything I have
ever seen. I don't want to believe that every major Java library with JPMS
support needs
Hello Ralph,
*TypeConverterRegistry changes*
Sorry for breaking certain tests. I had used the following to test my
changes: `./mvnw clean install -pl
:log4j-core,:log4j-layout-template-json`. I have tested my changes after
purging Log4j `2.*-SNAPSHOT` artifacts from my `~/.m2` and there I indeed
Also, Jenkins docs are usually in Jenkins itself like these useful
pages (I reference them every time I need to make non-trivial
changes):
https://ci-builds.apache.org/job/Logging/job/log4j/pipeline-syntax/
https://ci-builds.apache.org/job/Logging/job/log4j/pipeline-syntax/html
(warning: loong
https://github.com/apache/struts/blob/777caaade067b755b9aa4638f28ba8579d1c7a1d/Jenkinsfile#L32-L34
is the gist of how it's normally supposed to be configured for the
sh/bat steps. I'll figure out a specific fix later today.
On Sun, 4 Apr 2021 at 23:25, Ralph Goers wrote:
>
> Yes, I saw the mvn co
13 matches
Mail list logo
