Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-03 Thread Ralph Goers
I am now looking at the Jenkins and GitHub Actions builds and it is clear that the change I highlighted below has caused at 3 tests to fail. Please revert the change to the TypeConverterRegistry. In the future, whenever a change is made to the API or core components please make sure you run a fu

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-03 Thread Ralph Goers
Volkan, I haven’t looked at the details of what you changed in JsonTemplateLayout yet but the below concerns me a bit…. Ralph > On Apr 3, 2021, at 3:48 AM, v...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > Why were changes to the registry requi

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Apache
Yeah, sorry for not getting to that. I will still look at it though. Ralph > On Apr 3, 2021, at 3:19 AM, Volkan Yazıcı wrote: > > Ralph, I know you are pretty busy with the Java 11 migration on master. > I will merge this branch onto release-2.x and then cherry-pick into master. > I need to ge

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Volkan Yazıcı
Merging release-2.x worked, as expected. Cherry-picking the commit into master turned out to be quite hairy than I expected. I think I finally got it and pushed the changes to master. On Sat, Apr 3, 2021 at 12:18 PM Volkan Yazıcı wrote: > Ralph, I know you are pretty busy with the Java 11 migrat

Re: Master is merged

2021-04-03 Thread Gary Gregory
Great news, thank you Ralph! Gary On Sat, Apr 3, 2021, 01:50 Ralph Goers wrote: > I’ve merged the Java 11 changes to the master branch. To summarize: > Toolchains are no longer required. > Java11 (or later?) is required to build and run. However, I have only > tried with Java 11. > Log4j-api an

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Volkan Yazıcı
Ralph, I know you are pretty busy with the Java 11 migration on master. I will merge this branch onto release-2.x and then cherry-pick into master. I need to get this in, so that I can continue working on other JTL tickets. On Mon, Mar 22, 2021 at 9:54 PM Ralph Goers wrote: > I will try to get t