Re: Garbage Free Precise Time

2021-04-01 Thread Ralph Goers
> On Apr 1, 2021, at 10:38 PM, Ralph Goers wrote: > > In thinking about this problem I suspect we never noticed that the > PreciseClock version of our SystemClock class is not garbage free is because > we previously ran all of our unit tests with Java 8. Now that they are using > Java 11 t

Garbage Free Precise Time

2021-04-01 Thread Ralph Goers
In thinking about this problem I suspect we never noticed that the PreciseClock version of our SystemClock class is not garbage free is because we previously ran all of our unit tests with Java 8. Now that they are using Java 11 that code is being exercised. I’ve looked at java.time.Clock and

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-01 Thread Tim Perry
Looks okay on Windows. I built on Windows 10 with Zulu Java 8 / 11 in my toolchain and Maven 3.6.3 and it succeeded after I disabled the usual culprits: * log4j-core fails due to the file locking issue with the status logger * log4j-layout-template-json failed with a port unavailable issue. I

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-01 Thread Apache
Actually, they don’t disappear. They just move to closed status. I believe you can still comment but it is far less noticeable after it is merged. Really, I suggest you check out the branch and build it. I really didn’t change much code. I mostly moved it around and changed whatever was needed t