Re: Please do not commit to log4j2 master - but review this PR.

2021-03-29 Thread Ralph Goers
I should have added that you may need a recent version of the JDK. I forget what error I was encountering but upgrading the JDK to a later version fixed it. But then I noticed that the Google java allocation instrumenter wasn’t working and it had to be upgraded too. Ralph > On Mar 29, 2021, at

Re: Please do not commit to log4j2 master - but review this PR.

2021-03-29 Thread Matt Sicker
I’ll make sure to look more closely at it this week. Nice work on simplifying the modules a bit! On Sun, Mar 28, 2021 at 18:24 Ralph Goers wrote: > I have created https://github.com/apache/logging-log4j2/pull/480 for you > to review. It has many changes and merge conflicts will be painful to fix

Re: [log4cxx] ABI checks

2021-03-29 Thread Robert Middleton
> > As part of my goal of making log4cxx ABI compatible, I've added a new check > > to the Github actions that will run automatically to see if there are any > > ABI changes. Currently it's just sitting in a PR( > > https://github.com/apache/logging-log4cxx/pull/58) if anybody wants to > > check i

Re: [log4cxx] ABI checks

2021-03-29 Thread Thorsten Schöning
Guten Tag Robert Middleton, am Sonntag, 28. März 2021 um 04:24 schrieben Sie: > As part of my goal of making log4cxx ABI compatible, I've added a new check > to the Github actions that will run automatically to see if there are any > ABI changes. Currently it's just sitting in a PR( > https://git