Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Ralph Goers
Json-Template-layout is available in the staging site now. Ralph > On Mar 7, 2021, at 2:16 PM, Ralph Goers wrote: > > I will rebuild the site and update that one file. > > Ralph > >> On Mar 7, 2021, at 2:13 PM, Ralph Goers wrote: >> >> The generated site contains json-template-layout.vm.htm

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Ralph Goers
I will rebuild the site and update that one file. Ralph > On Mar 7, 2021, at 2:13 PM, Ralph Goers wrote: > > The generated site contains json-template-layout.vm.html in the manual > directory. I see json-template-layout.vm.adoc in the source, which I suspect > is the source of the problem. I

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Ralph Goers
The generated site contains json-template-layout.vm.html in the manual directory. I see json-template-layout.vm.adoc in the source, which I suspect is the source of the problem. I believe the file needs to be named json-template-layout.adoc.vm to be processed by velocity and end up with an adoc

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Volkan Yazıcı
Ah! If that is the case, definitely +1! (Sorry for the inconvenience.) On Sun, 7 Mar 2021, 22:06 Gary Gregory wrote: > I don't think we need to fail the RC if the site generation is the only > item impacted as opposed to the running software since its relatively easy > to fix the site after the

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Remko Popma
Sorry I won't have time to validate the release. But it looks like there are enough +1 votes to proceed, phew! :-) On Mon, Mar 8, 2021 at 5:58 AM Ralph Goers wrote: > See - https://issues.apache.org/jira/projects/MDOAP/issues/MDOAP-61. This > is documented as part of the release process. > > I d

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Ralph Goers
I should always add that something wrong with the web site would never be a -1 on a release vote. The web site can be updated at any time and doesn’t really require a vote. We tend to only update it at the time of release do to features being added or changes being made, but I have corrected mis

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Gary Gregory
I don't think we need to fail the RC if the site generation is the only item impacted as opposed to the running software since its relatively easy to fix the site after the release. Up to the RM of course ;-) Gary On Sun, Mar 7, 2021, 15:58 Ralph Goers wrote: > See - https://issues.apache.org/

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Volkan Yazıcı
Yes, that is from the website. Build the website with "./mvnw site", browse to "Layouts" and click to "JSON Template Layout" from the menu on the left. It used to work. Note that this might be a hiccup on my side too, hence I will really appreciate a confirmation. On Sun, 7 Mar 2021, 21:58 Ralph G

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Ralph Goers
See - https://issues.apache.org/jira/projects/MDOAP/issues/MDOAP-61. This is documented as part of the release process. I don’t understand the impact of the missing json-template-layout.html. Is that from the web site? Was it present in 2.14.0 and why is it missing now? Ralph > On Mar 7, 20

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Volkan Yazıcı
-1, due to missing `json-template-layout.html` file! `./mvnw site` fails for me thanks to maven-doap-plugin: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-doap-plugin:1.2:generate (site) on project log4j: Execution site of goal org.apache.maven.plugins:maven-doap-plugin:1.2:genera

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Matt Sicker
+1 Tested on macOS with Java 8. Didn't try compiling with newer Java as the default due to known issues with some hard-coded things. Signatures good, build and tests good. On Sun, 7 Mar 2021 at 08:48, Gary Gregory wrote: > > +1 > > Testing using the git tag for this RC: > > - mvn RAT check OK. >

Re: [log4cxx] Smart pointer implementation

2021-03-07 Thread Robert Middleton
I have just updated my PR with the new changes - at this point, the only class that we use from C++17 is std::shared_mutex, which has an equivalent implementation from boost. Currently, all builds on Github(Ubuntu, OSX, Windows) compile cleanly and pass all tests without boost. What I may do in t

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Gary Gregory
+1 Testing using the git tag for this RC: - mvn RAT check OK. - mvn clean install OK. - mvn revapi:check -pl log4j-api OK. - mvn revapi:check -pl log4j-1.2-api fails but with what looks like non-1.2 changes. Tested using: Macos: openjdk version "1.8.0_282" OpenJDK Runtime Environment (AdoptOpe