Ralph,
Thanks for the review. Yep, that *is* a problem...I knew it was a singleton
but didn't think through the use case you describe. This is ironic since a
few months ago I recommended that one of my clients bundle log4j in each
war rather than on Tomcat's classpath so there would be less chance
Gary,
As you know our FastDateParser was borrowed from Apache Commons and modified
for our purposes. You picked up bug fixes from Apache Commons several years
ago.
I noticed you posted that Apache Commons’ version of this class is failing a
test in Java-16 EA. Do you happen to know if our ver
Yeah, I started a review but then I thought it probably would be better to
respond here.
You are on the right track but there is a problem. StatusLogger is a singleton
- there is one instance anchored in a static. You are invoking the shutdown
logic from the shutdown of the LoggerContext which
Ralph,
I implemented what you suggested. Feel free to suggest improvements.
https://github.com/apache/logging-log4j2/pull/469
Tim
On Tue, Feb 23, 2021 at 2:14 PM Ralph Goers
wrote:
> I would suggest that if it is writing to something other than System.out
> that it be redirected back there and
Thanks for your understanding. As I said, I am not against routing them all to
JsonTemplateLayout but I can understand that that might be difficult.
We do need to make sure that the Layout documentation on the web site makes it
clear that JsonTemplateLayout is the preferred solution.
Ralph
>
I would suggest that if it is writing to something other than System.out that
it be redirected back there and then the OutputStream be closed. However, I’ve
not looked at the code recently so I am not sure what it takes to do that.
Ralph
> On Feb 23, 2021, at 2:22 PM, Tim Perry wrote:
>
> Tha
Thank you for the feedback. I'll put in a pull request.
On Tue, Feb 23, 2021 at 1:29 PM Volkan Yazıcı
wrote:
> I still would favor a PR – it greatly narrows down the scope one needs to
> wrap his/her head around. Not to mention the convenience of having the
> discussion "on the code".
>
> Ralph
I still would favor a PR – it greatly narrows down the scope one needs to
wrap his/her head around. Not to mention the convenience of having the
discussion "on the code".
Ralph appears to be the best candidate to answer your questions. But again,
a PR would incentivize others to chime in too.
One
Thank you, Volkan.
I'm not quite ready to submit a PR. I was hoping some of you with more
knowledge of log4j-core would weigh in on what we should do about shutting
down the StatusLogger.
My thought is we choose one of two options:
Option A:
1) check if any StatusLogger is writing to standard ou
I am dropping the case due to objections from other committers.
I have closed the GitHub PR and JIRA ticket for the deprecation of
log4j-layout-jackson* modules.
On Thu, Feb 18, 2021 at 4:10 PM Volkan Yazıcı
wrote:
> As the title suggests, in accordance with the aim of reducing the
> maintenance
Great work Tim! I can't be happier finally somebody stepping up to fix
sporadic build failures on Windows due to open file related issues. Would
you mind creating a PR, please? (I haven't missed one, right?) This will
make it easier to review your changes and merge them.
On Mon, Feb 22, 2021 at 8:
11 matches
Mail list logo
