[log4cxx] Smart pointer implementation

2021-02-17 Thread Robert Middleton
I now have a plausible implementation of log4cxx using smart pointers ready for review. Basic overview of the changes: * Removed all of the AddRef / ReleaseRef functions for the reference counting of objects, since that is now handled by the smart pointer * Added the ability to switch between cla

Re: What is going on with Master?

2021-02-17 Thread Tim Perry
Matt, The problem is: target\status.log failed with java.nio.file.FileSystemException: target\status.log: The process cannot access the file because it is being used by another process. I'm not familiar with how log4j should be releasing the log file to know where to look. I did notice the afterA

Re: What is going on with Master?

2021-02-17 Thread Tim Perry
Yes, I am on windows 10. I'm using Zulu OpenJdk for both Java 8 and 11, maven 3.6.3, and a fairly new Eclipse. I'd be happy to help you sort out the problem. It will be fun: I haven't played around with those junit features. On Wed, Feb 17, 2021 at 1:45 PM Matt Sicker wrote: > Is that on Windows

Re: What is going on with Master?

2021-02-17 Thread Matt Sicker
Is that on Windows? If so, there seems to be a bug I've introduced in the JUnit 5 code that I tried to port from the JUnit 4 code correctly, but I don't have a Windows machine to test that out on iteratively. See https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/test/java/org/apa

Re: What is going on with Master?

2021-02-17 Thread Tim Perry
I mean is that: * when I run "mvn install" on the command line then usually 1, but sometimes 2 tests fail. * when I right-click the src/tests/java folder in eclipse and do "run as JUnit" I get ~100 failures. I'm fairly sure the tests are *not* running in parallel. On Wed, Feb 17, 2021 at 1:11 PM

Re: What is going on with Master?

2021-02-17 Thread Matt Sicker
I think he's referring to the need to run mvn install once before the IDE will pick up snapshot jars for things like annotation processing or other fancy things. Simple way to reproduce: try running "mvn package" without the "install" target. On Wed, 17 Feb 2021 at 13:58, Ralph Goers wrote: > > Y

Re: What is going on with Master?

2021-02-17 Thread Ralph Goers
Yeah, there is a very good chance if you are trying to run tests in core in parallel on multiple threads that they will fail. Most of them expect their own LoggerContext. Ralph > On Feb 17, 2021, at 12:51 PM, Tim Perry wrote: > > On master, I noticed that when I build in my IDE that lots of t

Re: What is going on with Master?

2021-02-17 Thread Tim Perry
On master, I noticed that when I build in my IDE that lots of tests in log4j-core fail but when I build with maven they pass. In the past, when I've seen this on other projects it was caused by race conditions. I wonder: are there race conditions in the tests or the code that need to be addressed?

Re: [logging-log4j2] 02/02: Test RecyclerFactory read from XML config.

2021-02-17 Thread Volkan Yazıcı
Good to know. Thanks Matt! On Wed, Feb 17, 2021 at 4:12 PM Matt Sicker wrote: > FYI, the @Named injection has a default based on the parameter name > you annotate, so if you make them match (case matters), then you have > less to specify in the test. > > On Wed, 17 Feb 2021 at 08:10, wrote: > >

Re: [logging-log4j2] 02/02: Test RecyclerFactory read from XML config.

2021-02-17 Thread Matt Sicker
FYI, the @Named injection has a default based on the parameter name you annotate, so if you make them match (case matters), then you have less to specify in the test. On Wed, 17 Feb 2021 at 08:10, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > vy pushed a commi

Re: LOG4J2-3022 AsyncLogger with JDBC Appender PoolingDriver not concurrent

2021-02-17 Thread Gary Gregory
Yeah, and I use this appender at work! I should be able to look later today. Gary On Wed, Feb 17, 2021, 03:14 Volkan Yazıcı wrote: > Hello, > > This is a reminder for those who did not receive a notification for > LOG4J2-3022 > AsyncLogger with JDBC Appender PoolingDriver not concurrent >

LOG4J2-3022 AsyncLogger with JDBC Appender PoolingDriver not concurrent

2021-02-17 Thread Volkan Yazıcı
Hello, This is a reminder for those who did not receive a notification for LOG4J2-3022 AsyncLogger with JDBC Appender PoolingDriver not concurrent . @Gary Gregory , you appear to be the most active regarding JDBC appender. Hence your expertise wi

Review Request: Improve Logger javadoc for throwing() and catching()

2021-02-17 Thread Volkan Yazıcı
Hello, Would anybody mind reviewing the javadoc changes in GitHub #466 addressing LOG4J2-3020 LOG4J2-3021 , please? Cheers!