Re: LOG4J2-2624 and LOG4J2-1606

Matt, Thank you. If all is well, I’ll make the equivalent PR for the master branch. Tim Tim Perry (916) 505-3634 > On Jan 28, 2021, at 6:49 PM, Matt Sicker wrote: > > Great, thanks for the PR! I'll make sure to review this over the weekend. > >> On Thu, 28 Jan 2021 at 13:47, Tim Perry wr

Re: LOG4J2-2624 and LOG4J2-1606

Great, thanks for the PR! I'll make sure to review this over the weekend. On Thu, 28 Jan 2021 at 13:47, Tim Perry wrote: > > I submitted pull request 463 for this work. > https://github.com/apache/logging-log4j2/pull/463 > > Please let me know if there are any issues you would like me to address.

Re: Putting a ribbon around 2.14.1?

I'm going to do a wee bit of testing in my work env with MongoDb in the meantime... Gary On Thu, Jan 28, 2021, 10:38 Ralph Goers wrote: > Sure. I’m busy with $dayjob stuff anyway. > > Ralph > > > On Jan 28, 2021, at 4:02 AM, Volkan Yazıcı > wrote: > > > > For 2.14.1, would you wait for the res

Re: LOG4J2-2624 and LOG4J2-1606

I submitted pull request 463 for this work. https://github.com/apache/logging-log4j2/pull/463 Please let me know if there are any issues you would like me to address. Thank you, Tim On Tue, Jan 26, 2021 at 3:27 PM Tim Perry wrote: > Okay, I've fully updated the code to use JUnit 5. > > I'm th

Re: Putting a ribbon around 2.14.1?

Sure. I’m busy with $dayjob stuff anyway. Ralph > On Jan 28, 2021, at 4:02 AM, Volkan Yazıcı wrote: > > For 2.14.1, would you wait for the resolution of LOG4J2-2973 > , please? > I am helping Fabio Ricchiuti to put the fix >

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

Hi Volkan, I don't want to take the time to dig into the details but I am glad you found a resolution. My main concern is for binary compatibility of our call-site facing APIs, so breaking file formats is ok by me in this case. Gary On Thu, Jan 28, 2021, 05:59 Volkan Yazıcı wrote: > Gary, chec

Re: Putting a ribbon around 2.14.1?

For 2.14.1, would you wait for the resolution of LOG4J2-2973 , please? I am helping Fabio Ricchiuti to put the fix into its last shape. Once it lands on master, I will cherry-pick it to release-2.

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

Gary, check out the mess I caused by not accepting your proposal for renaming "type" to "format": LOG4J2-2973 . "type" conflicts with the array parsing semantics in properties file parser. Renaming "type" to "format" will allow us to read EventTemp