Okay, I've fully updated the code to use JUnit 5.
I'm thinking of naming the ServletContextListener that should be registered
as a listener in web.xml "Log4jShutdownOnContextDestroyedListener". In
my initial code it was named "Log4jServletDestroyedListenerTest" which
isn't very useful. The general
The release-2.x branch is the current stable branch, while master is
the 3.x branch right now. I'd suggest release-2.x since we're still
likely to make at least one (if not more) more 2.x release before 3.0,
though if you make a PR to both branches, that helps :)
On Tue, 26 Jan 2021 at 13:47, Tim
Yes, junit pulls in an old version of hamcrest. There are some nice
goodies in the newer hamcrest, but I just stuck with the existing
dependencies. I did upgrade everything to JUnit 5.
What is the best branch to base my pull request on? I'm going to
re-apply the changes to get a clean history: one
I had innocently just ported certain improvements from release-2.x to
master, this shouldn't have been the way I was rewarded. :S I will try
sparing some time on this today to fix the issue. Sorry for the
inconvenience.
On Mon, Jan 25, 2021 at 11:52 PM Mr. Jenkins
wrote:
> *BUILD UNSTABLE*
> Bui
