I believe that's already included. There's also AssertJ which might be
a dependency. No strong preferences from me, though; just try to use
the JUnit 5 API preferably as not everything has been migrated yet! :)
On Mon, 25 Jan 2021 at 15:06, Tim Perry wrote:
>
> Is it okay to import hamcrest to us
Is it okay to import hamcrest to use in the tests?
org.hamcrest
hamcrest
2.2
test
On Mon, Jan 25, 2021 at 10:44 AM Tim Perry wrote:
> Thank you, Matt.
>
> I'll get back to you after I've written some unit tests.
>
> Tim
>
> On Mon, Jan 25, 2021 at 10:37 AM Matt Sicker wrote:
Thank you, Matt.
I'll get back to you after I've written some unit tests.
Tim
On Mon, Jan 25, 2021 at 10:37 AM Matt Sicker wrote:
> Go to https://github.com/apache/logging-log4j2/compare and click the
> "compare across forks" link at the top to make a PR from your forked
> repo.
>
> On Mon, 25
Go to https://github.com/apache/logging-log4j2/compare and click the
"compare across forks" link at the top to make a PR from your forked
repo.
On Mon, 25 Jan 2021 at 12:15, Tim Perry wrote:
>
> Matt,
>
> Thanks for clarifying.
>
> I'd be happy to write some tests and submit a PR. How should I su
Matt,
Thanks for clarifying.
I'd be happy to write some tests and submit a PR. How should I submit a
pull request? I don't think I can do it from the github repo I linked to.
Thanks,
Tim
On Mon, Jan 25, 2021 at 9:59 AM Matt Sicker wrote:
> I'm just saying that I don't think any of the develo
I'm just saying that I don't think any of the developers here would
object to functional changes you'd like to introduce here, especially
if you think this change makes sense for users other than yourself.
If you submit your changes as a PR (and preferably add automated tests
if possible), we'd be
Matt, et al.,
I agree the deployment patterns you mention are more common and I wouldn't
start a new project embedding log4j in each WAR. However, I'm trying to
upgrade some old spring apps and my hands are tied on the deployment
pattern.
As mentioned in my comment on LOG4J2- 2624, the changes I
