Re: unable to build from source

2020-12-08 Thread Joseph Tsai
I have been trying to figure out why I'm failing the assertion test [image: image.png] So far from looking at LocalizedMessage.java [image: image.png] I think $locale is always null and therefore $bundle is always null, and this sets $msgPattern to $myKey which $myKey is just "hello_world". And ev

Re: LOG4J2-2965 deadlock brainstorming

2020-12-08 Thread Carter Kozak
Hi Remko, I had thought exactly the same thing until I drafted my email, but in doing so I came to the realization (hopefully correctly) that the problem is the direct result of jul.LogManager synchronizing initialization, so if we can avoid log4j initialization within the locked region and def

Re: LOG4J2-2965 deadlock brainstorming

2020-12-08 Thread Remko Popma
Hi Carter, I’m not sure if I understand the problem and your proposed solution fully but it sounds like it may reduce the probability of a deadlock occurring but not fully eliminate the possibility. (Without looking at the code, away from pc), would it be an idea to expose a status (or perhaps we

Re: unable to build from source

2020-12-08 Thread Ralph Goers
You are making progress! I saw those same errors in one of our automated builds the other day. I am not sure what the problem is but haven’t looked into it yet. Ralph > On Dec 8, 2020, at 9:23 AM, Joseph Tsai wrote: > > I kinda inferred that from reading the mvnw script when Volkan directed me

Re: LOG4J2-2965 deadlock brainstorming

2020-12-08 Thread Matt Sicker
As one of the biggest tinkerers in log4j-jul myself, I have to say that sounds like a decent idea. I haven't revisited my assumptions in that module in a long time as I haven't had to integrate with JUL lately (at least outside Jenkins, but there I'm using log4j-audit in a plugin which doesn't inte

Re: unable to build from source

2020-12-08 Thread Matt Sicker
The full build isn't compatible with Java 11 yet, so you need both 8 and 11 configured in a toolchains.xml config. Then you need to use Java 8 as the default JVM (or at least the contents of JAVA_HOME), and the build will switch to higher version compilers for the modules that require it. Ideally,

Re: unable to build from source

2020-12-08 Thread Volkan Yazıcı
Would you mind changing the default JDK you start *mvnw* to version 8 and retrying via *./mvnw clean package -DskipTests*, please? (Here *clean* goal is necessary for removing the class files compiled earlier with the wrong JDK.) [Sorry for the short answer, struggling with my day-job in the meanti

Re: unable to build from source

2020-12-08 Thread Joseph Tsai
Hi Volkan, I just installed both JDK8 and 11 and tried to do mvn clean install. The same error persists, and I think it's looking at my default Java installation? Running "sudo update-alternatives --config java" shows the following: [image: image.png] Currently it is defaulted to Java15, and every

Re: unable to build from source

2020-12-08 Thread Volkan Yazıcı
Hello Joseph, You need to have both JDK 8 and 11 installed and configured in your toolchains.xml file. For reference, you can check how we do it in GitHub Actions workflow: maven.yml and maven-toolchains.xml

unable to build from source

2020-12-08 Thread Joseph Tsai
Hi everyone, I forked and cloned the project from GitHub . And spent the past couple of hours trying to build from source with mvn install. It is failing with errors saying "class file has wrong version 55.0, should be 53.0" for "bad class file: /modules/