Re: Log4j JSON layout template Uris enum

2020-11-17 Thread Gary Gregory
[Please take this constructively despite my string words] Arg. As much as I love Effective Java and admire Joshua Bloch, this one feels like a brain fart, and Block even concedes this pattern "may feel a bit unnatural", no kidding. This is an ENUM, but it does NOT enumerate ANYTHING. It is only us

Re: Review request for LOG4J2-2962

2020-11-17 Thread Ralph Goers
I’ll see if I can find time later tonight. Ralph > On Nov 17, 2020, at 2:59 PM, Volkan Yazıcı wrote: > > In LOG4J2-2962, Magnus Kvalheim requests a functionality for the "map" > resolver similar to the one in "mdc". Guess what? They both operate on > `ReadOnlyStringMap`s and there goes my MR: >

Review request for LOG4J2-2962

2020-11-17 Thread Volkan Yazıcı
In LOG4J2-2962, Magnus Kvalheim requests a functionality for the "map" resolver similar to the one in "mdc". Guess what? They both operate on `ReadOnlyStringMap`s and there goes my MR: https://github.com/apache/logging-log4j2/pull/441 Here I merge the backends of both resolvers into one: `ReadOnlyS

The Apache Logging Services PMC welcomes Volkan Yazıcı to the PMC

2020-11-17 Thread Matt Sicker
Hello everyone, It's my pleasure to inform you that Volkan has accepted our invitation to join the Apache Logging Services PMC. Volkan originally developed the JsonTemplate layout in Log4j2 which was recently released in Log4j 2.14.0 and was previously distributed externally amongst other contribu

Re: Log4j JSON layout template Uris enum

2020-11-17 Thread Carter Kozak
I'm a big fan fan of enum singletons. This case looks like an enum with no values for utility methods to avoid a private ctor, I haven't used enums this way myself. I think the trade-off is between avoiding having to write a private constructor to prevent extension, and the downside of enum stat

Re: Log4j JSON layout template Uris enum

2020-11-17 Thread Volkan Yazıcı
I use enums for singletons, which is the recommended way to create singletons in Effective Java by Joshua Bloch. Given I have used it in some other places as well and heard no complaints so far, I did not convert them to a final class with a private ctor. Should I? On Tue, Nov 17, 2020 at 9:25 PM

Fwd: Log4j JSON layout template Uris enum

2020-11-17 Thread Gary Gregory
Hi all, Why is this an enum and not a class? Gary

Re: Jenkins build failure in JSON template module

2020-11-17 Thread Gary Gregory
Thank you Volkan! :-) Gary On Tue, Nov 17, 2020, 08:12 Volkan Yazıcı wrote: > revapi complaints. Fixed. > > On Mon, Nov 16, 2020 at 4:19 PM Gary Gregory > wrote: > > > Hi All, > > > > The Jenkins build is failing in the JSON template module. > > > > Gary > > >

Re: Jenkins build failure in JSON template module

2020-11-17 Thread Volkan Yazıcı
revapi complaints. Fixed. On Mon, Nov 16, 2020 at 4:19 PM Gary Gregory wrote: > Hi All, > > The Jenkins build is failing in the JSON template module. > > Gary >