Log4j 2.13.1 build status

2020-02-24 Thread Ralph Goers
I have fixed all the errors. I had to build the web site several times (each build takes almost an hour) before I finally realized what the problem with the download links was. I have run the release build but I still have to rebuild the web site 1 more time and it is too late for that tonight s

[CANCEL] [VOTE] Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
Due to the change from test scope to implicit compile scope for the SLF4J jars in Log4j core this vote is cancelled. Ralph

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
Wow. Thanks for pointing that out. I concur. Log4j API and core are not supposed to have any required dependencies other than Log4j itself. I will cancel this vote and create a new rc as soon as I can. Ralph > On Feb 24, 2020, at 2:37 PM, Marius Volkhart wrote: > > -1, dont release because >

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Marius Volkhart
-1, dont release because With this RC, the log4j-core artifact declares a dependency on the SLF4J API. Previously, it was only used in the test scope. The commit that introduced this change does not indicate why it is necessary. https://github.com/apache/logging-log4j2/commit/b727221e2c6889539d825

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
The requirements section and download links have been manually corrected on the site. Ralph > On Feb 24, 2020, at 9:17 AM, Matt Sicker wrote: > > Site notes: > > * Requirements section on home page should mention the Java 8 version > range now. It was mentioned in the News section already, bu

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
I haven't seen that error in a long time. I fixed all the problems against the automated windows builds and they no longer have errors. I also didn’t get any errors when I ran the build on my Windows 10 VM. Ralph > On Feb 24, 2020, at 9:34 AM, Gary Gregory wrote: > > Oops, sent previous mes

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
I also see the error with the actual download links. I will manually make that change and update the source to fix the problem. Ralph > On Feb 24, 2020, at 9:17 AM, Matt Sicker wrote: > > Site notes: > > * Requirements section on home page should mention the Java 8 version > range now. It was

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Ralph Goers
Apparently I forgot to push the web site changes. They are there now. Ralph > On Feb 24, 2020, at 9:14 AM, Gary Gregory wrote: > > TL;DR: > > > My review is based on the git tag > > - Apache RAT check OK. > - Can't find a way to run Apache CLIRR from the command line, so I am > relying on

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Gary Gregory
Oops, sent previous message by mistake. I meant: TL;DR building as specified below (Maven): [ERROR] Tests run: 25, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.178 s <<< FAILURE! - in org.apache.logging.log4j.core.impl.ThrowableProxyTest [ERROR] testLogStackTraceWithClassLoaderThatWithCa

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Matt Sicker
Site notes: * Requirements section on home page should mention the Java 8 version range now. It was mentioned in the News section already, but the Requirements one is now outdated. * Download links to 2.13.0 are still shown, and they're actually links to 2.12.1 for some reason. * Everywhere the re

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Gary Gregory
TL;DR: My review is based on the git tag - Apache RAT check OK. - Can't find a way to run Apache CLIRR from the command line, so I am relying on the site https://rgoers.github.io/log4j2-site -- Expected missing classes in Log4j 1.2 compatibility layer -- API report OK, but the text refers to org

Re: [VOTE] Release Log4j 2.13.1-rc1

2020-02-24 Thread Gary Gregory
On Mon, Feb 24, 2020 at 12:52 AM Ralph Goers wrote: > This is a vote to release Log4j 2.13.1, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... > > The vote will