Build failed in Jenkins: logging-log4net » PR-56 #1

2020-02-04 Thread Apache Jenkins Server
See Changes: -- Branch indexing Connecting to https://api.github.com using dpsenner/** (dpsenner at github) Loading trusted files from base branch master at c04a774240fd4500e

Re: Contributing LogstashLayout to Log4j core

2020-02-04 Thread Remko Popma
On Wed, Feb 5, 2020 at 6:14 Volkan Yazıcı wrote: > In its current form, JsonTemplateLayout exposes the following > timestamp accessors: > > - timestamp -- string, formatted according to the given > timestampFormatPattern) > > - timestamp:epoch[:divisor=[,integral]] -- double > (or long, if "i

Re: Contributing LogstashLayout to Log4j core

2020-02-04 Thread Volkan Yazıcı
In its current form, JsonTemplateLayout exposes the following timestamp accessors: - timestamp -- string, formatted according to the given timestampFormatPattern) - timestamp:epoch[:divisor=[,integral]] -- double (or long, if "integral" is provided) epoch nanoseconds divided by "divisor", i

Re: Best practices for editing the manual

2020-02-04 Thread Jochen Wiedmann
On Tue, Feb 4, 2020 at 10:29 AM Volkan Yazıcı wrote: > I have a couple of questions regarding working on the manual. I will > appreciate if you can spare some time to help me out with them: > > 1. What is the easiest Maven command just to get `/target/site` >generated? `./mvnw site` works, bu

Re: [jira] [Created] (LOG4J2-2771) Remove need for multiple JDKs during build

2020-02-04 Thread Ralph Goers
I am pretty sure I have run into other issues as well. I know all the stuff that is in the -java9 modules has counterparts that are based on Java 8 but I believe most of those use reflection to get at the stuff the compiler would fail at. However, you can’t just set the -source and -target optio

Re: Best practices for editing the manual

2020-02-04 Thread Ralph Goers
Yes, building the web site takes a long time. That is one of the reasons it takes so long to cut a release. The web site has to be built at least twice - once before the release to verify it and fix bugs, and again after the release to build the “real” web site. I would prefer a better way to

Re: Necessity of multiple JDKs for build

2020-02-04 Thread Matt Sicker
Yikes that's a good point. Any idea if animal-sniffer prevents that, too? On Tue, 4 Feb 2020 at 11:01, Gary Gregory wrote: > > Compiling on Java 9 or above will break Java 8 clients if we have code that > complies against Buffer classes. > > Gary > > On Tue, Feb 4, 2020, 08:49 Volkan Yazıcı wrot

Re: Necessity of multiple JDKs for build

2020-02-04 Thread Gary Gregory
Compiling on Java 9 or above will break Java 8 clients if we have code that complies against Buffer classes. Gary On Tue, Feb 4, 2020, 08:49 Volkan Yazıcı wrote: > Okay. I've created a ticket[1] for this. Note that once this is done, > migration to GitHub Actions[2] becomes straightforward. (Ma

Re: [jira] [Created] (LOG4J2-2771) Remove need for multiple JDKs during build

2020-02-04 Thread Gary Gregory
The problem is that this will mess up Java 8 clients when code compiled against various Buffer classes runs due to methods added or tweaked in Java 9's Buffer classes. Gary Gary On Tue, Feb 4, 2020, 08:46 Volkan Yazici (Jira) wrote: > Volkan Yazici created LOG4J2-2771: > --

Re: Best practices for editing the manual

2020-02-04 Thread Gary Gregory
You can short circuit the tests with -DskipTests Gary On Tue, Feb 4, 2020, 04:29 Volkan Yazıcı wrote: > Hello, > > I have a couple of questions regarding working on the manual. I will > appreciate if you can spare some time to help me out with them: > > 1. What is the easiest Maven command just

Re: Necessity of multiple JDKs for build

2020-02-04 Thread Volkan Yazıcı
Okay. I've created a ticket[1] for this. Note that once this is done, migration to GitHub Actions[2] becomes straightforward. (Marked [1] as a blocker for [2].) [1] https://issues.apache.org/jira/browse/LOG4J2-2771 [2] https://issues.apache.org/jira/browse/LOG4J2-2764 On Tue, Feb 4, 2020 at 2:24

Re: Necessity of multiple JDKs for build

2020-02-04 Thread Matt Sicker
There are some compile errors if you try to use 11 for everything. If those are fixed, we can likely use 11 for the whole build with animal sniffer or something configured to prevent using incorrect APIs. On Tue, Feb 4, 2020 at 03:07 Volkan Yazıcı wrote: > Hello, > > Would somebody mind remindin

Best practices for editing the manual

2020-02-04 Thread Volkan Yazıcı
Hello, I have a couple of questions regarding working on the manual. I will appreciate if you can spare some time to help me out with them: 1. What is the easiest Maven command just to get `/target/site` generated? `./mvnw site` works, but is taking ages. 2. What is the recommended practice f

Necessity of multiple JDKs for build

2020-02-04 Thread Volkan Yazıcı
Hello, Would somebody mind reminding me why do we need multiple JDKs for build rather than just sticking to 11 and tuning the target version whenever necessary? Kind regards.