Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Ralph Goers
I did some a benchmark as I had the same thought. FastDateFormat is faster than java.time. Ralph > On Jan 29, 2020, at 7:34 AM, Matt Sicker wrote: > > Oh right. We might’ve checked that out at one point. Escape analysis might > optimize away some of the garbage, but not predictably. > > On We

Re: The convention for thread-local allocations (TLAs)

2020-01-29 Thread Volkan Yazıcı
In the PR that I am working on JsonTemplateLayout, I have updated ThreadLocalVsPoolBenchmark. I am struggling to explain the results[1]. I will appreciate some feedback here. [1] https://github.com/apache/logging-log4j2/pull/335#issuecomment-579835151 On Sat, Dec 28, 2019 at 11:27 PM Ralph Goers

Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Matt Sicker
Oh right. We might’ve checked that out at one point. Escape analysis might optimize away some of the garbage, but not predictably. On Wed, Jan 29, 2020 at 05:53 Volkan Yazıcı wrote: > To the best of my knowledge, FastDateFormat is garbage-free and > available options in JDK 8+ are not. > > On Tu

Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Volkan Yazıcı
To the best of my knowledge, FastDateFormat is garbage-free and available options in JDK 8+ are not. On Tue, Jan 28, 2020 at 11:40 PM Matt Sicker wrote: > > I've started browsing through your PR. It's given me a tangential > question that I didn't feel like leaving on the PR: I see the > continue