Re: Contributing LogstashLayout to Log4j core

2020-01-28 Thread Matt Sicker
As a bonus, your PR is complex enough that I may end up being able to showcase how the redone dependency injection system I've been working on can simplify things in 3.x. Everything is organized nicely for it! On Tue, 28 Jan 2020 at 16:40, Matt Sicker wrote: > > I've started browsing through your

Re: Contributing LogstashLayout to Log4j core

2020-01-28 Thread Matt Sicker
I've started browsing through your PR. It's given me a tangential question that I didn't feel like leaving on the PR: I see the continued use of our FastDateTime classes from Commons, and now I'm wondering if we still need to use this in Java 8? Could be worth exploring. I also noted some clarific

Contributing LogstashLayout to Log4j core

2020-01-28 Thread Volkan Yazıcı
I've just created a PR[1] contributing LogstashLayout to Log4j core. Please see the GitHub link for the feedback/support requests. I will appreciate a quick review cycle, since I will try my best to invest quite some time into this during FOSDEM. [1] https://github.com/apache/logging-log4j2/pull/3

Re: Using builtin plugins with different ClassLoaders

2020-01-28 Thread Matt Sicker
There’s certainly an interesting use case here that seems to have uncovered a CL bug. The deferred plugin loading thing is an idea, though the precedence rules described seem like a good starting point for a potential bug? On Tue, Jan 28, 2020 at 08:01 Sebastián Zaffarano wrote: > Hi there! > I'

Using builtin plugins with different ClassLoaders

2020-01-28 Thread Sebastián Zaffarano
Hi there! I'm having a problem with an application (an app container) that manages different ClassLoaders for different apps that it has deployed. We built a custom ContextSelector that manages different contexts based on classloaders to isolate different configurations for many apps running in th