Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Matt Sicker
Unsubscribe by mailing dev-unsubscr...@logging.apache.org On Fri, 17 Jan 2020 at 13:05, Valentina Ichimov wrote: > > Please unsubscribe me from here > > Thanks > > În vin., 17 ian. 2020 la 8:45 p.m. Gary Gregory a > scris: > > > On Fri, Jan 17, 2020 at 10:01 AM Gary Gregory > > wrote: > > > > >

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Valentina Ichimov
Please unsubscribe me from here Thanks În vin., 17 ian. 2020 la 8:45 p.m. Gary Gregory a scris: > On Fri, Jan 17, 2020 at 10:01 AM Gary Gregory > wrote: > > > Does this help: > https://logging.apache.org/log4j/2.x/manual/layouts.html > > > > But basically you cannot collapse the 2 since you wa

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Gary Gregory
On Fri, Jan 17, 2020 at 10:01 AM Gary Gregory wrote: > Does this help: https://logging.apache.org/log4j/2.x/manual/layouts.html > But basically you cannot collapse the 2 since you want to be able to pretty- vs. compact-print AND you want to terminate the whole thing with an optional NUL. Gary

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Gary Gregory
On Fri, Jan 17, 2020 at 12:50 PM Matt Sicker wrote: > On Fri, 17 Jan 2020 at 07:44, Volkan Yazıcı > wrote: > > (Sorry for spamming the list. Is there a FreeNode channel or sth > > similar where I can direct my questions to?) > > I believe this is exactly the purpose of the dev@ mailing list. Tho

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Matt Sicker
On Fri, 17 Jan 2020 at 07:44, Volkan Yazıcı wrote: > (Sorry for spamming the list. Is there a FreeNode channel or sth > similar where I can direct my questions to?) I believe this is exactly the purpose of the dev@ mailing list. Though there's a logging Slack channel on the-asf. -- Matt Sicker

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Jochen Wiedmann
On Fri, Jan 17, 2020 at 2:10 PM Volkan Yazıcı wrote: > Isn't it possible to combine this into a single "String eol"? Sounds reasonable, except that one should use a byte array, rather that a string, shouldn't one? Jochen

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Gary Gregory
Does this help: https://logging.apache.org/log4j/2.x/manual/layouts.html Gary On Fri, Jan 17, 2020 at 8:44 AM Volkan Yazıcı wrote: > Gary, would you mind explaining the interaction between the following > fields, please? > > boolean eventEol (What does this denote?) > String endOfLine

Re: PluginAttributeBuilder-vs-PluginAttribute

2020-01-17 Thread Matt Sicker
Yes, that’s a good idea. On Fri, Jan 17, 2020 at 04:44 Volkan Yazıcı wrote: > Shall we remove the @deprecated entry in javadocs until the design is > finalized and merged to master? > > On Thu, Jan 16, 2020 at 5:49 PM Matt Sicker wrote: > > > > Yeah, I'm still working on some fundamental change

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Volkan Yazıcı
Let me add header/footer getters to the list of components whose interaction is still mysterious for me. On Fri, Jan 17, 2020 at 2:45 PM Volkan Yazıcı wrote: > > Gary, would you mind explaining the interaction between the following > fields, please? > > boolean eventEol (What does this denote

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Volkan Yazıcı
Gary, would you mind explaining the interaction between the following fields, please? boolean eventEol (What does this denote?) String endOfLine boolean compact String eol boolean includeNullDelimiter At first, I thought "compact" is just used to enable pretty-printing, but th

JDK 14 is now in Rampdown Phase Two

2020-01-17 Thread Rory O'Donnell
 Hi Ralph, *Per the JDK 14 schedule , we are now in Rampdown Phase Two * *Please advise if you have any open high priority issues.* ** * The overall feature set is frozen. o No further JEPs will be targeted to this release o Per the JDK Release Process [1] we now turn our focus to P

Re: final modifier in method args and local variables

2020-01-17 Thread Gary Gregory
So you might as well follow convention ;-) Gary On Fri, Jan 17, 2020 at 8:16 AM Ralph Goers wrote: > That is a convention Gary imitated. If you don’t add the final keywords > you can be sure Gary will do it. > > Ralph > > > On Jan 17, 2020, at 3:55 AM, Volkan Yazıcı > wrote: > > > > Hello, > >

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Gary Gregory
On Fri, Jan 17, 2020 at 8:16 AM Ralph Goers wrote: > Makes sense to me. > Not to me ;-) The optional NULL is to end an event. An EOL is to end a line when you are not using a compact format. Gary > > Ralph > > > On Jan 17, 2020, at 6:11 AM, Volkan Yazıcı > wrote: > > > > Jackson layouts acce

Re: eol and null-delimiter in Jackson layouts

2020-01-17 Thread Ralph Goers
Makes sense to me. Ralph > On Jan 17, 2020, at 6:11 AM, Volkan Yazıcı wrote: > > Jackson layouts accept the following two parameters: > >String eol >boolean includeNullDelimiter > > Their purpose is simple: > >logEvent(event); >writer.write(eol); >if (includeNullDelimiter

Re: final modifier in method args and local variables

2020-01-17 Thread Ralph Goers
That is a convention Gary imitated. If you don’t add the final keywords you can be sure Gary will do it. Ralph > On Jan 17, 2020, at 3:55 AM, Volkan Yazıcı wrote: > > Hello, > > I don't want to turn this into a religious war, but is having final > modifier on both method arguments and local

eol and null-delimiter in Jackson layouts

2020-01-17 Thread Volkan Yazıcı
Jackson layouts accept the following two parameters: String eol boolean includeNullDelimiter Their purpose is simple: logEvent(event); writer.write(eol); if (includeNullDelimiter) { writer.write('\0'); } Isn't it possible to combine this into a single "String eol"

Re: final modifier in method args and local variables

2020-01-17 Thread Gary Gregory
I'm not sure if we flag missing final keywords in Checkstyle/PMD/Spotbugs but I know projects that do. I'm all for keeping on using final, it's one less thing to consider when grooking code please see https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ Gary On Fri, Jan 17, 2020

final modifier in method args and local variables

2020-01-17 Thread Volkan Yazıcı
Hello, I don't want to turn this into a religious war, but is having final modifier on both method arguments and local variables a convention that *must* be followed or some legacy followed blindly? Because if I can opt out, I would prefer so. Regards.

Re: PluginAttributeBuilder-vs-PluginAttribute

2020-01-17 Thread Volkan Yazıcı
Shall we remove the @deprecated entry in javadocs until the design is finalized and merged to master? On Thu, Jan 16, 2020 at 5:49 PM Matt Sicker wrote: > > Yeah, I'm still working on some fundamental changes to annotations, > but it will still be backward compatible with what already worked > be