Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Ralph Goers
So add @Ignore to that one test. Ralph > On Dec 9, 2019, at 10:18 PM, Gary Gregory wrote: > > The problem is that it prevents from running a full build on Windows in > sane manner. I can skip the tests but that does not give me confidence :-( > > Gary > > On Mon, Dec 9, 2019 at 10:49 PM Ralph

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Gary Gregory
The problem is that it prevents from running a full build on Windows in sane manner. I can skip the tests but that does not give me confidence :-( Gary On Mon, Dec 9, 2019 at 10:49 PM Ralph Goers wrote: > Having looked at the test it is checking for “\n\t” in the result. The > test should not d

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Ralph Goers
Having looked at the test it is checking for “\n\t” in the result. The test should not do that. I will modify it but I don’t think that is a reason to block the release, assuming it gets enough votes. Ralph > On Dec 9, 2019, at 8:44 PM, Ralph Goers wrote: > > OK, that test was added 2 days af

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Ralph Goers
OK, that test was added 2 days after the last release in August. I guess that means you haven’t done a full build since then? Ralph > On Dec 9, 2019, at 8:42 PM, Ralph Goers wrote: > > Oh wait, I am looking at the wrong class. Let me check again. > > Ralph > >> On Dec 9, 2019, at 8:40 PM, Ra

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Ralph Goers
Oh wait, I am looking at the wrong class. Let me check again. Ralph > On Dec 9, 2019, at 8:40 PM, Ralph Goers wrote: > > That test class hasn’t been modified since the last release. I obviously > don’t get that error on my Mac and I have run the build many times, so it > must be something Wi

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Ralph Goers
That test class hasn’t been modified since the last release. I obviously don’t get that error on my Mac and I have run the build many times, so it must be something Windows related. Is that the only problem you encountered with the release? Ralph > On Dec 9, 2019, at 12:28 PM, Gary Gregory

Re: [VOTE] Release Log4j 2.13.0-rc1

2019-12-09 Thread Gary Gregory
I get this failure running 'mvn clean package': [ERROR] Failures: [ERROR] LoggerTest.builder:69 Incorrect message 3 Expected: a string starting with " WARN Log4j rocks! java.lang.Throwable: This is a test\n\tat org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:65)" but: was " WARN