Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Ralph Goers
I don’t understand. You can’t add javax.inject stuff into our namespace without changing the package name. And if you change the package name I don’t see any benefit at all as the current names are much clearer. I have no problem with Configurations being a plugin except it will currently cause

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Matt Sicker
I'm thinking that the old annotations can be supported in terms of the javax.inject API. As for requiring a jar, that's why I've also suggested just adopting the annotations into our own package somewhere. Either way this is done, my general goal is to untangle other areas in the core API that cou

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Ralph Goers
I don’t see how that relates. The proposal as I understand it is to replace the existing annotations with annotations from javax.inject, which would require a JEE jar. Ralph > On Oct 8, 2019, at 1:31 PM, Jochen Wiedmann wrote: > > On Tue, Oct 8, 2019 at 10:26 PM Ralph Goers > wrote: >> >>

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Ralph Goers
I also don’t think it is a good idea for other reasons: 1. The annotations you are reeferencing a s replacements for the current ones seem to be a stretch. For example it isn’t clear to me why @Qualifier has anything to do with @PluginAttribute. It just seems far more confusing. 2. You would stil

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Jochen Wiedmann
On Tue, Oct 8, 2019 at 10:26 PM Ralph Goers wrote: > > IIUC this will require a dependency on a Java EE jar? For that reason alone, > no. Don't think so. A simple (mostly JSR 330 compliant) provider can be implemented in a few classes: https://github.com/jochenw/afw/tree/master/afw-core/src/ma

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Ralph Goers
IIUC this will require a dependency on a Java EE jar? For that reason alone, no. Ralph > On Oct 8, 2019, at 1:23 PM, Gary Gregory wrote: > > That sounds good Matt, I say go for it. > > Gary > > On Tue, Oct 8, 2019, 16:08 Matt Sicker wrote: > >> I've been doing some experiments with the pl

Re: [Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Gary Gregory
That sounds good Matt, I say go for it. Gary On Tue, Oct 8, 2019, 16:08 Matt Sicker wrote: > I've been doing some experiments with the plugin system for 3.x > lately, and I've recently pushed some changes toward that end. One of > the insights I gained from it was that some of our plugin annota

[Java] Proposal: replacing plugin annotations with javax.inject ones

2019-10-08 Thread Matt Sicker
I've been doing some experiments with the plugin system for 3.x lately, and I've recently pushed some changes toward that end. One of the insights I gained from it was that some of our plugin annotations were redundant (result: @PluginBuilderFactory merged into @PluginFactory; @PluginBuilderAttribu