Re: Jenkins build became unstable: Log4j 2 3.x #476

Just a small inconsistency I found while refactoring. I fixed the issue I caused already. On Sat, Aug 31, 2019 at 23:15, Ralph Goers wrote: > I don’t understand. What is the problem? As you noted it has always been > this way. > > Ralph > > > On Aug 31, 2019, at 9:03 PM, Matt Sicker wrote: > >

Re: Jenkins build became unstable: Log4j 2 3.x #476

I don’t understand. What is the problem? As you noted it has always been this way. Ralph > On Aug 31, 2019, at 9:03 PM, Matt Sicker wrote: > > The plugin category is used to distinguish that in this API, not the class. > It seems as though both use the same interface except for the one class.

Re: Jenkins build became unstable: Log4j 2 3.x #476

The plugin category is used to distinguish that in this API, not the class. It seems as though both use the same interface except for the one class. Generic type erasure avoided this from cropping up before. On Sat, Aug 31, 2019 at 20:50, Ralph Goers wrote: > > Because it isn’t a PatternConverte

Re: Jenkins build became unstable: Log4j 2 3.x #476

Because it isn’t a PatternConverter? Look at what it does. The newInstance method creates a DatePatternConverter. The FileDatePatternConverter and IntegerPatternConverter are both used for the filePattern in the rolling file appender, not for a pattern layout. Ralph > On Aug 31, 2019, at 12

Re: Jenkins build became unstable: Log4j 2 3.x #476

Ah, this is an interesting historical design decision dating back to the very first commit! Why exactly does DatePatternConverter _not_ implement PatternConverter like literally every other converter class does? On Sat, 31 Aug 2019 at 14:29, Matt Sicker wrote: > > Shit, I'm on it. > > On Sat, 31

Re: Jenkins build became unstable: Log4j 2 3.x #476

FileDatePatternConverter, not DatePatternConverter. On Sat, 31 Aug 2019 at 14:35, Matt Sicker wrote: > > Ah, this is an interesting historical design decision dating back to > the very first commit! Why exactly does DatePatternConverter _not_ > implement PatternConverter like literally every othe

Re: Jenkins build became unstable: Log4j 2 3.x #476

Shit, I'm on it. On Sat, 31 Aug 2019 at 13:50, Apache Jenkins Server wrote: > > See > > -- Matt Sicker