Well, I just noticed that GcFreeSynchronousLoggingTest is generating a bunch of
errors. It seems some of the patterns in gcFreeLogging.xml have location info
in the patterns so StackTraceElements are being created. It would probably be
simpler to honor the flag then try to reconcile the issues.
Never answer email from the phone. It spell checks everything wrong.
Ralph
> On Jul 2, 2019, at 3:54 PM, Ralph Goers wrote:
>
> I am using these because the reporter provided them. I will convert them to
> John at some point.
>
> Log4J 3.0 is the master branch. Since it uses java 8 some thing
I am using these because the reporter provided them. I will convert them to
John at some point.
Log4J 3.0 is the master branch. Since it uses java 8 some things are easier to
do than on release-2.x. The withLocation test uses the new builder I add to the
api. The witHLocation method doesn’t hav
If memory serves correctly, the `includeLocation` was introduced because it was
necessary for async loggers (and it seemed not feasible to get this information
from the layout pattern).
Async loggers need to know upfront whether they need to pass location
information to the consumer thread.
But what do you think about includeLocation. Should it override the result of
requiresLocation or should the fact that we determined location information is
required override the includeLocation setting?
Ralph
> On Jul 2, 2019, at 2:34 PM, Matt Sicker wrote:
>
> These benchmarks are impressiv
These benchmarks are impressive! Moving the point of call site calculation
is a great idea.
On Tue, 2 Jul 2019 at 16:22, Ralph Goers wrote:
> I have made changes to the code the master branch to measure and improve
> performance. I have committed some of the changes but not the last set. I
> hav
I have made changes to the code the master branch to measure and improve
performance. I have committed some of the changes but not the last set. I have
not made the latest changes to release-2.x because they will have to be
implemented a bit differently to avoid compatibility issues. The table b
