Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Matt Sicker
The java setup has me blocked currently for developing more complicated code where I want to use inline test execution in my IDE. It’s not a blocker for building, though. On Thu, Jun 27, 2019 at 19:51, Gary Gregory wrote: > On Thu, Jun 27, 2019 at 8:06 PM Ralph Goers > wrote: > > > So does this

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Gary Gregory
On Thu, Jun 27, 2019 at 8:06 PM Ralph Goers wrote: > So does this mean you won’t be voting on this release even though it > behaves the same as the previous releases? > I am struggling with it. I am still looking for a way to test with Java 11... it feels pretty bad that we cannot say anything a

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Matt Sicker
I’ll be voting. I just haven’t had a chance to test it out yet (busy week). On Thu, Jun 27, 2019 at 19:06, Ralph Goers wrote: > So does this mean you won’t be voting on this release even though it > behaves the same as the previous releases? > > Ralph > > > On Jun 27, 2019, at 11:08 AM, Gary Gre

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Ralph Goers
So does this mean you won’t be voting on this release even though it behaves the same as the previous releases? Ralph > On Jun 27, 2019, at 11:08 AM, Gary Gregory wrote: > > On Thu, Jun 27, 2019 at 2:06 PM Ralph Goers > wrote: > >> What was the last release where you could build and test wit

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Matt Sicker
Try the full commit: https://github.com/apache/logging-log4j2/commit/acbd23054492ba71878a4aeebf03c92a0bcf7aa1 On Thu, 27 Jun 2019 at 12:18, Ralph Goers wrote: > > The vote is a little over half-way through and so far only Remko has voted. I > haven’t seen anything yet that would make me vote aga

Re: Do I need to clear programmatic loggers/appenders

2019-06-27 Thread Ralph Goers
Why are you dynamically creating loggers? I know of no valid reason to do that. Ralph > On Jun 27, 2019, at 11:38 AM, Gaurav wrote: > > I am creating millions of loggers. As, the logger is requested at runtime, I > cannot store the configuration in the static log4j2.xml. So, I create a > roll

Re: Do I need to clear programmatic loggers/appenders

2019-06-27 Thread Gaurav
I am creating millions of loggers. As, the logger is requested at runtime, I cannot store the configuration in the static log4j2.xml. So, I create a rolling file appender and attach it to a logger. On 2019/06/27 13:14:28, Ralph Goers wrote: > You are creating millions of Loggers or millions o

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Gary Gregory
On Thu, Jun 27, 2019 at 2:06 PM Ralph Goers wrote: > What was the last release where you could build and test with Java 11? > AFAIK this problem is not new to this release. > No idea, sorry. Gary > > Ralph > > > On Jun 27, 2019, at 10:54 AM, Gary Gregory > wrote: > > > > Running the build on

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Gary Gregory
On Thu, Jun 27, 2019 at 1:54 PM Gary Gregory wrote: > Running the build on Java 8 was fine for me. I am concerned that it is not > testable on Java 11 in the usual Maven way. I cannot find a way to run the > tests without Maven deciding it needs to recompile everything. > I tried "touch"-ing all

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Ralph Goers
What was the last release where you could build and test with Java 11? AFAIK this problem is not new to this release. Ralph > On Jun 27, 2019, at 10:54 AM, Gary Gregory wrote: > > Running the build on Java 8 was fine for me. I am concerned that it is not > testable on Java 11 in the usual Mave

Re: [Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Gary Gregory
Running the build on Java 8 was fine for me. I am concerned that it is not testable on Java 11 in the usual Maven way. I cannot find a way to run the tests without Maven deciding it needs to recompile everything. Gary On Thu, Jun 27, 2019 at 1:18 PM Ralph Goers wrote: > The vote is a little ove

[Discuss] Release Log4j 2.12.0-rc2

2019-06-27 Thread Ralph Goers
The vote is a little over half-way through and so far only Remko has voted. I haven’t seen anything yet that would make me vote against the release so we still need one more vote before tomorrow night. All the issues found so far are very minor. Matt, as I said I tried applying the changes you

Re: [VOTE] Release Log4j 2.12.0-rc2

2019-06-27 Thread Matt Sicker
I made it a JUnit assume so it would ignore the test when the class isn't found. I think I made a Hamcrest matcher for it. On Wed, 26 Jun 2019 at 23:04, Ralph Goers wrote: > > I tried porting the changes you made back to release-2.x and it compiles, but > it still fails in the unit tests as the

Re: Do I need to clear programmatic loggers/appenders

2019-06-27 Thread Ralph Goers
You are creating millions of Loggers or millions of LoggerConfigs? What you are doing is incomplete. But why would you be dynamically creating millions of Loggers and Appenders? Whatever you are doing I am sure there is a better way to do it. Can you please describe your use case and why you thi

Do I need to clear programmatic loggers/appenders

2019-06-27 Thread Gaurav
Hi all, My application creates millions of loggers and appenders. I'm worried about the memory usage. For that, I am doing following things. 1.Remove appender from LoggerConfig. 2.Stop the LoggerConfig. 3. Remove logger from Configuration. But when I do the performance test, it prints the error