Re: PR for LOG4J2-2639

2019-06-22 Thread Matt Sicker
This pattern might be useful for the Scala and Kotlin adapters since those languages have some form of compile time macros (or at least Scala does, as does Groovy). Though that could even fill in the location info directly rather than walking the call stack at runtime. On Sat, Jun 22, 2019 at 12:2

Re: PR for LOG4J2-2639

2019-06-22 Thread Ralph Goers
Yes. Ralph > On Jun 22, 2019, at 9:54 AM, Gary Gregory wrote: > > I would drop prefixes like "at" and "with". > > In you example, if debug logging is disabled, are the follow up calls noops? > > Gary (AFK) > > On Sat, Jun 22, 2019, 11:58 Ralph Goers wrote: > >> Please review the PR for LOG

Re: PR for LOG4J2-2639

2019-06-22 Thread Gary Gregory
I would drop prefixes like "at" and "with". In you example, if debug logging is disabled, are the follow up calls noops? Gary (AFK) On Sat, Jun 22, 2019, 11:58 Ralph Goers wrote: > Please review the PR for LOG4J2-2639 at > https://github.com/apache/logging-log4j2/pull/284 < > https://github.co

PR for LOG4J2-2639

2019-06-22 Thread Ralph Goers
Please review the PR for LOG4J2-2639 at https://github.com/apache/logging-log4j2/pull/284 . This adds new Logger methods to allow a builder pattern to be used to accumulate the parameters to a logging call before logging the event. I got this i