Re: [logging-log4j-audit] branch LOG4J2-2579 updated (8fcfbb5 -> 998525c)

2019-05-28 Thread Matt Sicker
Oh, and note that GitHub isn’t typically that great at notifying people in a PR when a force push happens. More of an issue for reviewers of a PR I think, not a branch in general. On Tue, May 28, 2019 at 12:41, Matt Sicker wrote: > That’s up to you. I’ve been using forks lately because that’s ho

Re: [logging-log4j-audit] branch LOG4J2-2579 updated (8fcfbb5 -> 998525c)

2019-05-28 Thread Matt Sicker
That’s up to you. I’ve been using forks lately because that’s how all Jenkins related repositories are configured (we avoid shared branches due to some Jenkins issue ironically). Just note that if you force push to a shared branch, please make sure to note that on the dev list so that others know

Re: [logging-log4j-audit] branch LOG4J2-2579 updated (8fcfbb5 -> 998525c)

2019-05-28 Thread Andrei Ivanov
Sorry about that, I wasn't sure how to handle adding a trivial import cleanup change to my PR, that's why I've ammended the last commit. I wanted to leave the existing commits separate, so squashing wasn't an option (or maybe I could have squashed just the last 2 commits?) Basically I chose option