Re: CI for Log4j Audit

2019-05-07 Thread Ralph Goers
I took a glance at the log. I suspect it is something wrong in the test but I won’t be able to look at it until the workday is done. Ralph > On May 7, 2019, at 9:52 AM, Ralph Goers wrote: > > The “restrict where this job can be run” setting is trial and error. We > occasionally have Jenkins j

Re: CI for Log4j Audit

2019-05-07 Thread Matt Sicker
It might be easier to use a pipeline than a free style project, but maybe that's just me. You should be able to use https://github.com/apache/logging-log4j2/blob/master/Jenkinsfile and simplify it a bit as I doubt we need to run the tests on so many JDKs. You can create a pipeline build to edit the

Re: CI for Log4j Audit

2019-05-07 Thread Ralph Goers
The “restrict where this job can be run” setting is trial and error. We occasionally have Jenkins jobs blow up because the slave wasn’t set up for something that causes our jobs to fail so we manually exclude them. We would have to look at the test failures. Having them work on our laptops and

Re: CI for Log4j Audit

2019-05-07 Thread Matt Sicker
Oh, and you might want to disable email notifications until you figure out the configuration first. ;) On Tue, 7 May 2019 at 11:48, Matt Sicker wrote: > > It might be easier to use a pipeline than a free style project, but > maybe that's just me. You should be able to use > https://github.com/apa

Re: CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
I've copied the "Log4j 2 2.x" job and adjusted it and now there is https://builds.apache.org/view/L/view/Logging/job/Log4j%20Audit/ :-) I hope the label for "Restrict where this project can be run" is ok. I've read through the pom.xml and I've enabled the "integration-tests" profile, with a plan t

Re: CI for Log4j Audit

2019-05-07 Thread Matt Sicker
Great! On Tue, 7 May 2019 at 10:50, Andrei Ivanov wrote: > > Seems to work now, thanks :-) > > On Tue, May 7, 2019 at 6:48 PM Matt Sicker wrote: > > > Alright, I just added him to the hudson-jobadmin group. Andrei, can > > you check again? Might need to log out, not sure. > > > > On Tue, 7 May 2

Re: CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
Seems to work now, thanks :-) On Tue, May 7, 2019 at 6:48 PM Matt Sicker wrote: > Alright, I just added him to the hudson-jobadmin group. Andrei, can > you check again? Might need to log out, not sure. > > On Tue, 7 May 2019 at 10:39, Ralph Goers > wrote: > > > > I just reviewed the Jenkins wik

Re: CI for Log4j Audit

2019-05-07 Thread Matt Sicker
Alright, I just added him to the hudson-jobadmin group. Andrei, can you check again? Might need to log out, not sure. On Tue, 7 May 2019 at 10:39, Ralph Goers wrote: > > I just reviewed the Jenkins wiki which says you have to be in the appropriate > LDAP group. Unfortunately, only the PMC chair

Re: CI for Log4j Audit

2019-05-07 Thread Ralph Goers
I just reviewed the Jenkins wiki which says you have to be in the appropriate LDAP group. Unfortunately, only the PMC chair has update authority in that tool so Matt will have to fix this for you. Ralph > On May 7, 2019, at 8:26 AM, Ralph Goers wrote: > > At the very top of the menu on the le

Re: CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
Yes, that's where I was looking at, I see directly the "People" link, instead of the "New Item". On Tue, May 7, 2019 at 6:26 PM Ralph Goers wrote: > At the very top of the menu on the left under the Jenkins logo you should > see a “New Item” link. If you don’t then you don’t have the correct > p

Re: CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
I was able to log in, but I don't think I have enough permissions, I can only see the jobs and run them, but not configure new items. On Tue, May 7, 2019 at 6:10 PM Matt Sicker wrote: > I’m somewhat familiar with it if you need help. That may sound like an > understatement, but alas, that’s the

Re: CI for Log4j Audit

2019-05-07 Thread Ralph Goers
At the very top of the menu on the left under the Jenkins logo you should see a “New Item” link. If you don’t then you don’t have the correct permissions. Ralph > On May 7, 2019, at 8:22 AM, Andrei Ivanov wrote: > > I was able to log in, but I don't think I have enough permissions, I can > onl

Re: [Log4j] Groovy Configuration DSL

2019-05-07 Thread Matt Sicker
A Kotlin DSL would be pretty awesome. We’d first need a good way to generate all the relevant type metadata to do code generation. Or it might work better for a scripted DSL since you’d be using actual types of things. On Tue, May 7, 2019 at 09:11, Raman Gupta wrote: > A follow-on feature could

Re: CI for Log4j Audit

2019-05-07 Thread Matt Sicker
I’m somewhat familiar with it if you need help. That may sound like an understatement, but alas, that’s the difference between being a developer and user of a product sometimes. Miss the forest for the trees so to say. 😁 On Tue, May 7, 2019 at 09:57, Ralph Goers wrote: > Use your ASF credentials

Re: CI for Log4j Audit

2019-05-07 Thread Ralph Goers
Use your ASF credentials. If you aren’t aware of it, you can manage your credentials at id.apache.org . Ralph > On May 7, 2019, at 6:58 AM, Andrei Ivanov wrote: > > I don't have that much experience with it, but I can try :-) > > What about Jenkins credentials/permissio

Re: [Log4j] Groovy Configuration DSL

2019-05-07 Thread Raman Gupta
A follow-on feature could be a Kotlin DSL. Kotlin is fully typed, but with a lot of Groovy-like features that enable elegant DSLs. The Gradle team, for example, has created a Kotlin DSL that can be used instead of their Groovy DSL. I don't know the details of how it works, but IntelliJ is able to p

Re: CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
I don't have that much experience with it, but I can try :-) What about Jenkins credentials/permissions? On Tue, May 7, 2019 at 3:14 PM Apache wrote: > If you are familiar with Jenkins you should just be able to create one. > > Ralph > > > On May 7, 2019, at 12:53 AM, Andrei Ivanov > wrote: >

Re: LOG4J2-913 Code Reviews

2019-05-07 Thread Carter Kozak
Thanks Ralph! On Mon, May 6, 2019, at 13:31, Ralph Goers wrote: > Carter, thanks for the code review comments. I will try to address them over > the next couple of days and probably won’t comment on them until then so > please don’t think I am ignoring them. But if you find stuff that you > abs

Re: CI for Log4j Audit

2019-05-07 Thread Apache
If you are familiar with Jenkins you should just be able to create one. Ralph > On May 7, 2019, at 12:53 AM, Andrei Ivanov wrote: > > Hi, > I'm trying to see if there's a CI job defined for the Audit project. > > I'm looking at https://builds.apache.org/view/L/view/Logging/ and I don't > see o

CI for Log4j Audit

2019-05-07 Thread Andrei Ivanov
Hi, I'm trying to see if there's a CI job defined for the Audit project. I'm looking at https://builds.apache.org/view/L/view/Logging/ and I don't see one. If I am correct, how can one be defined? Regards, Andrei