> On Nov 5, 2018, at 2:33, Gary Gregory wrote:
>
> Some notes.
>
> Java 8 provides a java.time package. It would be nice to reuse it instead
> of keeping our own Java 7-based code.
>
> We provide a MutableInstant class akin to the final immutable thread-safe
> java.time.Instant class.
>
> Ou
I am sure we can find a way to eliminate our custom time code or base it on
java.time. Whether it performs better or not would require that it be tested
and compared. It wouldn’t be a simple matter to create a JMH benchmark and
create our time formatting against java.time.
Ralph
> On Nov 4, 20
Some notes.
Java 8 provides a java.time package. It would be nice to reuse it instead
of keeping our own Java 7-based code.
We provide a MutableInstant class akin to the final immutable thread-safe
java.time.Instant class.
Our class is not interchangeable with java.time.Instant but it could be a
On Sun, Nov 4, 2018 at 9:53 AM Ralph Goers
wrote:
> Did you make a Jira for that? I would like to focus on 3.0 but I have so
> little time…
>
> FWIW, I just ran the build on my laptop and had no problems.
>
I did not make a JIRA. The Jenkins build fails as well.
java.lang.AssertionError: expect
Did you make a Jira for that? I would like to focus on 3.0 but I have so little
time…
FWIW, I just ran the build on my laptop and had no problems.
Ralph
> On Nov 4, 2018, at 9:37 AM, Gary Gregory wrote:
>
> On Sun, Nov 4, 2018 at 9:34 AM Matt Sicker wrote:
>
>> The day of daylight saving ti
On Sun, Nov 4, 2018 at 9:34 AM Matt Sicker wrote:
> The day of daylight saving time ending or starting has historically caused
> failing unit tests. I’m not sure if that was ever fixed. Time is hard 😓
>
I am hoping that once we put more effort into 3.0 we can move to using the
Java 8 time APIs.
The day of daylight saving time ending or starting has historically caused
failing unit tests. I’m not sure if that was ever fixed. Time is hard 😓
On Sun, Nov 4, 2018 at 10:22, Gary Gregory wrote:
> Hi All:
>
> After commit 65fa087093a6de16e284e3189fda303f4b0111ab in master, the
> test TimeFilte
Hi All:
After commit 65fa087093a6de16e284e3189fda303f4b0111ab in master, the
test TimeFilterTest started failing. That commit removed deprecated tests
and updated one API call from deprecated to not deprecated. This makes me
wonder how the change could have caused this test to fail.
Any ideas?
W
