The updated PR looks good to me.
Remko.
(Shameless plug) Every java main() method deserves http://picocli.info
> On Nov 4, 2018, at 1:11, Carter Kozak wrote:
>
> The PR looks good to me as well.
>
> As a future improvement we may want to fall back on a failed lookup on
> Level.getName() to L
I've also put together an updated release guide based on the Log4j 2 one:
https://cwiki.apache.org/confluence/display/LOGGING/Log4j+Kotlin+API+Release+Process
On Sat, 3 Nov 2018 at 15:16, Matt Sicker wrote:
> GPG keys:
> https://dist.apache.org/repos/dist/release/logging/KEYS
>
> Signed by Matt
GPG keys:
https://dist.apache.org/repos/dist/release/logging/KEYS
Signed by Matt Sicker (748F15B2CF9BA8F024155E6ED7C92B70FA1C814D).
Site:
https://jvz.github.io/log4j-api-kotlin-staging/
Maven Central artifacts:
https://repository.apache.org/content/repositories/orgapachelogging-1040/
Git:
git c
Whoops, not sure how I missed that. Let me try again.
On Sat, 3 Nov 2018 at 13:25, Ralph Goers wrote:
> -1
>
> The source zip is supposed to be an exact copy of the source repo. It is
> missing lots of stuff from the root directory, including the license and
> notice.
>
> Ralph
>
> > On Nov 3, 2
-1
The source zip is supposed to be an exact copy of the source repo. It is
missing lots of stuff from the root directory, including the license and notice.
Ralph
> On Nov 3, 2018, at 10:46 AM, Matt Sicker wrote:
>
> It's time again to try and release Log4j Kotlin API 1.0.0.
>
> GPG keys:
>
It's time again to try and release Log4j Kotlin API 1.0.0.
GPG keys:
https://dist.apache.org/repos/dist/release/logging/KEYS
Signed by Matt Sicker (748F15B2CF9BA8F024155E6ED7C92B70FA1C814D).
Site:
https://jvz.github.io/log4j-api-kotlin-staging/
Maven Central artifacts:
https://repository.apache
Alright, I'm closing this vote and starting a new release candidate.
On Sat, 3 Nov 2018 at 10:10, Matt Sicker wrote:
> Time slipped away yesterday. Doing this today. After this release, I’ll
> request infra move this repo to GitBox as well so we can start using GitHub
> directly.
>
> On Fri, Nov
The PR looks good to me as well.
As a future improvement we may want to fall back on a failed lookup on
Level.getName() to Level.getStandardLevel().getName() for the closest
matching standard level style.
On Sat, Nov 3, 2018 at 11:47 AM Gary Gregory wrote:
>
> Marco: Thank you for updating your P
Marco: Thank you for updating your PR.
Remko: The PR has been changed to use String keys instead of Levels. LGTM.
WDYT?
Gary
On Thu, Oct 25, 2018 at 12:57 AM Marco Herrn wrote:
> Hello,
>
> I expected that the second approach would be desired.
>
> I have changed the pull requests accordingly. C
Time slipped away yesterday. Doing this today. After this release, I’ll
request infra move this repo to GitBox as well so we can start using GitHub
directly.
On Fri, Nov 2, 2018 at 08:54, Matt Sicker wrote:
> Thanks for taking a look! I’ll review this today and hopefully can kick
> off a new vot
10 matches
Mail list logo
