Re: Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-10-24 Thread Marco Herrn
Hello, I expected that the second approach would be desired. I have changed the pull requests accordingly. Can you please recheck? Best regards Marco On Thu, Oct 25, 2018 at 07:29:28AM +0900, Remko Popma wrote: > Creating custom Levels in HighLightConverter feels wrong to me. > > It’s possi

Re: GC Free Layouts

2018-10-24 Thread Volkan Yazıcı
One thing I am still struggling is how to iterate over ContextData and ContextStack without any garbage. ContextData#forEach() necessitates instantiation of a new BiConsumer. And likewise, ContextStack necessitates instantiation of a new Iterator for traversal. Am I missing something? Is there any

Re: Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-10-24 Thread Remko Popma
Creating custom Levels in HighLightConverter feels wrong to me. It’s possible to register custom log levels programmatically as well as in configuration (https://logging.apache.org/log4j/2.x/manual/customloglevels.html). If the user has not defined the log levels by the time the HighLightCon

Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-10-24 Thread Marco Herrn
Hello, I have prepared a pull request for LOG4J2-2405. There is still one decision to be made how to handle custom log levels. I added my comments to the pull request, but duplicate it here to have a broader audience for discussing it: To allow styles for unknown log levels the HighlightConverte

Pull Request for [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

2018-10-24 Thread Marco Herrn
Hi, I just realized that I accidently posted my original message to the user mailing list instead of the dev mailing list. So here I just announce the Pull Request I made and only reference my original mail below. Best regards Marco --- Well, I have now split those tests