Re: GC Free Layouts

2018-10-22 Thread Remko Popma
Looks very nice! The non garbage-free implementation is in the toSerializable(LogEvent) method. As you point out, this often ends in a call to StringBuilder.toString(). The garbage-free implementation is in the encode(LogEvent, ByteBufferDestination) method. This reuses a ThreadLocal StringBui

Re: Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, TimeUnit)

2018-10-22 Thread Remko Popma
I’ll take a look. > On Oct 23, 2018, at 4:38, Gary Gregory wrote: > > In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, > TimeUnit), I see: > > 1) we stop the async appender > 2) notify ReliabilityStrategies that appenders will be stopped > 3) we stop the sync appender

GC Free Layouts

2018-10-22 Thread Volkan Yazıcı
Hello, I am working on the next release of log4j2-logstash-layout , which is an alternative to the default JsonLayout and allows custom JSON schemas. There I achieved to get up to 5x speed up compared to JsonLayout[1] and I want to

Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, TimeUnit)

2018-10-22 Thread Gary Gregory
In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, TimeUnit), I see: 1) we stop the async appender 2) notify ReliabilityStrategies that appenders will be stopped 3) we stop the sync appender I wonder if (2) was added in the wrong place and should come before (1)? Gary

Travis CI build broken

2018-10-22 Thread Gary Gregory
See https://travis-ci.org/apache/logging-log4j2/builds/54266?utm_source=github_status&utm_medium=notification Gary

Fwd: log4net / .ner core 2.1 / SmtpAppender

2018-10-22 Thread Dominik Psenner
Apparently I forgot to add dev at logging dot apache dot org to the recipients. Here comes the last message as a forward. -- Forwarded message - From: Dominik Psenner Date: Mon, 22 Oct 2018 at 13:57 Subject: Re: log4net / .ner core 2.1 / SmtpAppender To: Michael Karmazin (public)

Re: log4net / .ner core 2.1 / SmtpAppender

2018-10-22 Thread Michael Karmazin (public)
Hi Dominik, Thanks for the quick reply. Ok gotcha, good to know that core 2.1 is at least on the cards. As for getting involved: I'd be happy too... when I've got time. As the first and minimum thing, I can start using the release branch now. I understand it's the 'release/2.1.0' branch - ok I'll