Re: New time classes and Java 8

2018-01-27 Thread Gary Gregory
On Sat, Jan 27, 2018 at 4:28 PM, Remko Popma wrote: > Well, we can’t use java.time.Instant in LogEvent and still be garbage > free. So that’s a bigger discussion. > > You have reviewed the code, so I hope you agree, but I think our new time > code is pretty clean. One could argue that the transla

Re: [log4j] The shape of Log4j

2018-01-27 Thread Ralph Goers
Also, in Java 9 it must only require the java.base module. Ralph > On Jan 27, 2018, at 6:49 PM, Matt Sicker wrote: > > On 27 January 2018 at 16:18, Ralph Goers wrote: > >> The requirement is that log4j-core have no required dependencies. I should >> have as few optional dependencies as possib

Re: [log4j] The shape of Log4j

2018-01-27 Thread Matt Sicker
On 27 January 2018 at 16:18, Ralph Goers wrote: > The requirement is that log4j-core have no required dependencies. I should > have as few optional dependencies as possible. > That sounds perfectly reasonable. LMAX and Jackson are good examples. -- Matt Sicker

Re: Soliciting input: ElasticSearch receiver

2018-01-27 Thread Matt Sicker
On the sending side, we'd want to be able to configure index name, mapping type name, override mapping settings, bulk request (i.e., batch) size, refresh interval overrides, something similar to the column mappings thing in the Cassandra and JDBC plugins, authentication, could be missing some ideas

Re: Soliciting input: ElasticSearch receiver

2018-01-27 Thread Remko Popma
Sorry I won’t be able to help you with that; no experience with ElasticSearch. Remko (Shameless plug) Every java main() method deserves http://picocli.info > On Jan 28, 2018, at 9:48, Scott Deboy wrote: > > I'm looking at adding an ES receiver and was curious what folks would > like to see w

Soliciting input: ElasticSearch receiver

2018-01-27 Thread Scott Deboy
I'm looking at adding an ES receiver and was curious what folks would like to see when it comes to configuration options/capabilities, other than the ability to continually retrieve new events on some polling interval, which I'll make sure to add. Scott

Re: New time classes and Java 8

2018-01-27 Thread Remko Popma
Well, we can’t use java.time.Instant in LogEvent and still be garbage free. So that’s a bigger discussion. You have reviewed the code, so I hope you agree, but I think our new time code is pretty clean. One could argue that the translation from epochSeconds to epochMillis is duplication from j

Re: [log4j] The shape of Log4j

2018-01-27 Thread Ralph Goers
> On Jan 27, 2018, at 9:39 AM, Gary Gregory wrote: > > Should a goal be that log4j-core have no external dependencies? The requirement is that log4j-core have no required dependencies. I should have as few optional dependencies as possible. Ralph

Re: [log4j] The shape of Log4j

2018-01-27 Thread Matt Sicker
Moving the Kafka and ZeroMQ appenders to their own modules sounds like a good start! Appenders that require third party plugins seem to be a great candidate for splitting into their own modules. On 27 January 2018 at 16:06, Gary Gregory wrote: > As a first cut I was thinking of moving out Kafka

Re: [log4j] The shape of Log4j

2018-01-27 Thread Gary Gregory
As a first cut I was thinking of moving out Kafka and ZeroMQ. The other stuff is interesting... Gary On Jan 27, 2018 3:01 PM, "Matt Sicker" wrote: > On 27 January 2018 at 10:39, Gary Gregory wrote: > > > Should a goal be that log4j-core have no external dependencies? > > > > This would be diff

Re: Regression from 2.9.1 to 2.10.0 - win7/jdk1.8.0_152 - always getting ERROR StatusLogger Log4j2 could not find a logging implementation.

2018-01-27 Thread Matt Sicker
That looks rather strange. Have you tried flipping the order of the classpath? On 27 January 2018 at 11:54, wrote: > I am always getting: ERROR StatusLogger Log4j2 could not find a logging > implementation. Please add log4j-core to the classpath. Using SimpleLogger > to log to the console... >

Re: [log4j] The shape of Log4j

2018-01-27 Thread Matt Sicker
On 27 January 2018 at 10:39, Gary Gregory wrote: > Should a goal be that log4j-core have no external dependencies? > This would be difficult without shading in LMAX Disruptor. Either that, or we may need some log4j-core API tweaks to allow the AsyncLogger code to live in its own module (which wo

[log4j] RollingAppenderDirectWriteTempCompressedFilePatternTest

2018-01-27 Thread Gary Gregory
Hi: FYI: If my PC is busy and slow at times, the test RollingAppenderDirectWriteTempCompressedFilePatternTest fails. In wonder if we could re-write the test to check for success and failure until AFTER the logger context is stopped. Gary

Regression from 2.9.1 to 2.10.0 - win7/jdk1.8.0_152 - always getting ERROR StatusLogger Log4j2 could not find a logging implementation.

2018-01-27 Thread Mark.Roder
I am always getting: ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console... Happens in eclipse oxygen. Also happens in this sample program. Works fine in 2.9.1, but not in 2.10.0 Request a J

New time classes and Java 8

2018-01-27 Thread Gary Gregory
Hi Remko: Curious: How much bending over backward are we doing with this new time code by _not_ using Java 8? Gary

Regression from 2.9.1 to 2.10.0 - win7/jdk1.8.0_152 - always getting ERROR StatusLogger Log4j2 could not find a logging implementation.

2018-01-27 Thread Mark.Roder
I am always getting: ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console... Happens in eclipse oxygen. Also happens in this sample program. Request a JIRA be created on this issue and corrected in

Re: [log4j] The shape of Log4j

2018-01-27 Thread Gary Gregory
Should a goal be that log4j-core have no external dependencies? Gary On Sat, Jan 27, 2018 at 12:57 AM, Remko Popma wrote: > Perhaps https://issues.apache.org/jira/browse/LOG4J2-2226 (Log4j2 > modularization) can also function as the epic for moving towards the plugin > API that Matt mentioned.