Re: [log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Ralph Goers
Then I don’t understand why you modified MapMessage to be public class MapMessage, V> and the getData method returns has the signature public Map getData() If you are putting arbitrary stuff in the Map then this signature is wrong. Ralph > On Jan 11, 2018, at 11:29 PM, Gary Gregory wrote: >

Re: [log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Gary Gregory
Hi Ralph, I will have to look at the generics in the morning but my requirement from day one is that a MapMessage allow values of any type (String keys are fine.) where each value in a MapMessage can be of a different types. A specific Appender can decide what to do with the values. Having all Str

Re: [log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Ralph Goers
In looking at the history MapMessage only supported Strings until you modified it last June. It appears to me you did it incorrectly. You made MapMessage generic but left the put and putAll methods as only supporting String values. I am not sure why you would have done that instead of having the

[log4j] Jenkins failing randomly on OSGi tests

2018-01-11 Thread Gary Gregory
Still not sure why, but Jenkins is still failing randomly on OSGi tests. I thought it was a Windows thing since I see the failures locally too, but that does not look like it. Gary

Re: [log4cxx] State of this project?

2018-01-11 Thread Robert Middleton
Not sure if it helps you at all, but I do have a branch that will build with libapr(not apr2) that uses CMake if you want to try it out: https://github.com/rm5248/logging-log4cxx/tree/cmake-updates -Robert Middleton On Thu, Jan 11, 2018 at 10:25 AM, James E. King, III wrote: > Hello, > > I have

Re: [log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Gary Gregory
I can use one of the with() methods so no big deal. Gary On Thu, Jan 11, 2018 at 4:23 PM, Ralph Goers wrote: > I will have to look but as I recall I did that for a reason. > > Sent from my iPhone > > > On Jan 11, 2018, at 3:37 PM, Gary Gregory > wrote: > > > > It seems to me that: > > > > org.

Re: [log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Ralph Goers
I will have to look but as I recall I did that for a reason. Sent from my iPhone > On Jan 11, 2018, at 3:37 PM, Gary Gregory wrote: > > It seems to me that: > > org.apache.logging.log4j.message.MapMessage.put(String, String) > > should really be: > > org.apache.logging.log4j.message.MapMessa

[log4j] org.apache.logging.log4j.message.MapMessage.put(String, String)

2018-01-11 Thread Gary Gregory
It seems to me that: org.apache.logging.log4j.message.MapMessage.put(String, String) should really be: org.apache.logging.log4j.message.MapMessage.put(String, Object) Thoughts? Gary

[Log4j] Messages and garbage free logging

2018-01-11 Thread Mikael Ståldal
In http://logging.apache.org/log4j/2.x/manual/messages.html we say: "Although it may seem more expensive than passing the message format and parameters directly to the event, testing has shown that with modern JVMs the cost of creating and destroying events is minor, especially when complex ta

Re: [log4cxx] State of this project?

2018-01-11 Thread Pedro Lamarão
Em 11/01/2018 13:25, James E. King, III escreveu: I was able to build on linux against the apr-2 trunk as well by telling it that "--with-apr" and "--with-apr-util" come from the same location, since apr-util merged into apr. I am able to build with latest Gradle and Visual Studio 2017. I have

Re: [log4cxx] State of this project?

2018-01-11 Thread Thorsten Schöning
Guten Tag James E. King, III, am Donnerstag, 11. Januar 2018 um 16:25 schrieben Sie: > I have used log4cxx for a number of years and the last official release was > 7 years ago. There was an effort to make a 0.11.x release in October but I > don't see the result of that, There is none currently.

Re: [log4cxx] State of this project?

2018-01-11 Thread Gary Gregory
Hi James, It seems this project needs some fresh energy. I am active on the Log4j 2 side, but not on this one. Can anyone else provide guidance? Gary On Thu, Jan 11, 2018 at 8:25 AM, James E. King, III wrote: > Hello, > > I have used log4cxx for a number of years and the last official release

[log4cxx] State of this project?

2018-01-11 Thread James E. King, III
Hello, I have used log4cxx for a number of years and the last official release was 7 years ago. There was an effort to make a 0.11.x release in October but I don't see the result of that, plus it looks like all Windows based build projects and tools have been removed from the trunk. There are a