Re: [log4j] providing sourcewith Message

2017-12-22 Thread Matt Sicker
Is there no mangled method name generated? For example, inside a lambda, the function might be called Foo$1 like with Java 8 lambdas. On 22 December 2017 at 14:18, Ralph Goers wrote: > I am concerned because users can create customer Appenders and Layouts > that will be affected by a change to t

Re: [log4j] release 2.10.1

2017-12-22 Thread Matt Sicker
That OSGi test failure looks like one that could maybe be solved by doing a "mvn install -DskipTests" first as it's trying to find a snapshot jar. On 22 December 2017 at 23:17, Ralph Goers wrote: > I ran the build again and this time it succeeded. I didn’t get the OSGi > error you are seeing. >

Re: [log4j] release 2.10.1

2017-12-22 Thread Ralph Goers
I ran the build again and this time it succeeded. I didn’t get the OSGi error you are seeing. Ralph > On Dec 22, 2017, at 4:07 PM, Gary Gregory wrote: > > Arg. Tests pass for me in log4j-api. When I run 'mvn clean install', the > build blows up in log4j-osgi: > > ERROR StatusLogger No log4j2

Re: [log4j] release 2.10.1

2017-12-22 Thread Gary Gregory
Arg. Tests pass for me in log4j-api. When I run 'mvn clean install', the build blows up in log4j-osgi: ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console. Set system property 'log4j2.debug' to show Log4j2 internal initialization l

Re: [log4j] release 2.10.1

2017-12-22 Thread Ralph Goers
I reported that the build failed for me 2 weeks ago and never heard anything. I just tried it again and now I get a failure in log4j-api. I can’t perform releases while there are build failures. [ERROR] Tests run: 53, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.929 s <<< FAILURE! - in o

Re: [log4j] providing sourcewith Message

2017-12-22 Thread Ralph Goers
I am concerned because users can create customer Appenders and Layouts that will be affected by a change to the signature of getSource() in the LogEvent. I suspect that there are other things that use the LogEvent (the Logging Server? Lillith?) that would be impacted by this. Ralph > On Dec 22

Re: [log4j] providing sourcewith Message

2017-12-22 Thread Jeffrey Shaw
I didn't know about clirr, but I can try running that. I tried to not break any existing public methods. I created SourceLocation because I think for Scala macros, the method name can not exist, but StackTraceElement requires a method name. I'll double check this. On Thu, Dec 21, 2017 at 12:40 AM

[log4j] release 2.10.1

2017-12-22 Thread Gary Gregory
Time to release? We have small set of changes that fits in a maintenance x.x.1 release. Gary

[log4j] getCallerClass()

2017-12-22 Thread Ralph Goers
Reflection.getCallerClass() has been removed in Java 10 [1]. The pre-Java 9 version is already sensitive to this so it shouldn’t cause any problems. Ralph [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050713.html