Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Remko Popma
IgnoreException doesn’t fit: We’re not going to use Jansi by default, so the user needs a way to explicitly request Jansi somehow. Gary expressed a preference for configuration over system properties hence the idea of `loadJansi` or `enableJansi` as a ConsoleAppender attribute. But we can keep

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Matt Sicker
We have an ignoreExceptions option for when exceptions are thrown while appending a log event. Why not add another for ignoring exceptions thrown during construction of the plugin? It should ideally be filterable based on at least the exception supertype, but any sort of filter like that could be u

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Gary Gregory
On Tue, Oct 24, 2017 at 5:47 PM, Remko Popma wrote: > Mikael, I also don’t like the negative properties. > > Gary, we could remove the `log4j.skipJansi` system property altogether and > instead have an explicit ConsoleAppender config attribute like `loadJansi` > (or something). > This still feel

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Remko Popma
Mikael, I also don’t like the negative properties. Gary, we could remove the `log4j.skipJansi` system property altogether and instead have an explicit ConsoleAppender config attribute like `loadJansi` (or something). Note by the way that `disableAnsi` is for all ANSI escape codes and is not

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Mikael Ståldal
If we are going to rename it, I would like to invert it to "log4j2.enableJansi" (default false). I think negative properties with true default are confusing. On 2017-10-24 15:04, Remko Popma wrote: You mean let’s replace all occurrences of `log4j.skipJansi` with `log4j2.skipJansi`, in both c

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Gary Gregory
Wait a sec: How do I enable Jansi in my app _without_ fiddling with system properties? System properties should be considered a hack for things that can't be done in the configuration file. Gary On Tue, Oct 24, 2017 at 8:04 AM, Matt Sicker wrote: > Yes. New property names should all start with

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Matt Sicker
Yes. New property names should all start with "log4j2.", although I did make it so that no matter what naming scheme you use, they all get normalized to log4j2.camelCaseName. On 24 October 2017 at 08:04, Remko Popma wrote: > You mean let’s replace all occurrences of `log4j.skipJansi` with > `log

Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-24 Thread Remko Popma
You mean let’s replace all occurrences of `log4j.skipJansi` with `log4j2.skipJansi`, in both code and documentation? > On Oct 24, 2017, at 14:03, Matt Sicker wrote: > > Can you use the new system property naming scheme? This would be > log4j2.skipJansi. That property would work regardless wit