[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread kenneth mcfarland (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108338#comment-16108338 ] kenneth mcfarland commented on LOG4J2-1997: --- https://github.com/apache/logging-

[GitHub] logging-log4j2 pull request #104: LOG4J-1997 Cleanup of deprecated methods, ...

2017-07-31 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/104 LOG4J-1997 Cleanup of deprecated methods, warnings and use of try-with-resource to remove resource leaks. You can merge this pull request into a Git repository by running: $ git pull h

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108314#comment-16108314 ] ASF GitHub Bot commented on LOG4J2-1997: Github user kpm1985 closed the pull requ

[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...

2017-07-31 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread kenneth mcfarland (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108267#comment-16108267 ] kenneth mcfarland commented on LOG4J2-1997: --- Great point, I'll clean it up afte

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108260#comment-16108260 ] ASF GitHub Bot commented on LOG4J2-1997: Github user garydgregory commented on th

[GitHub] logging-log4j2 issue #103: LOG4J2-1997 Remove deprecated methods and close r...

2017-07-31 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/103 The resources are still leaking if the tests fail midway through a method. How about using try-with-resources clauses? --- If your project is set up for it, you can reply to this email

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108255#comment-16108255 ] ASF GitHub Bot commented on LOG4J2-1997: GitHub user kpm1985 opened a pull reques

[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...

2017-07-31 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/103 LOG4J2-1997 Remove deprecated methods and close resource leaks. This closes the jira. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kpm

[jira] [Created] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread kenneth mcfarland (JIRA)
kenneth mcfarland created LOG4J2-1997: - Summary: Test classes do not close resources and use deprecated methods Key: LOG4J2-1997 URL: https://issues.apache.org/jira/browse/LOG4J2-1997 Project: Log

Re: [Log4j] log4j-server

2017-07-31 Thread Gary Gregory
I plan on moving log4j-server back into the main repo. There is some odd Maven cycle thing going on ATM that breaks the main repo build. It also makes no sense to me in tools, which should for _tools_ like the DAT file plugin we talked a while ago that would collect various DAT files and make them

[GitHub] logging-log4j-tools issue #1: create test-jar, which is used by the log4j-co...

2017-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/logging-log4j-tools/pull/1 Adding the configuration to the parent pom cause the build to fail: ``` [INFO] --- maven-jar-plugin:3.0.0:test-jar (default) @ log4j-tools --- [WARNING] JAR will be

[GitHub] logging-log4j-tools pull request #1: create test-jar, which is used by the l...

2017-07-31 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/logging-log4j-tools/pull/1 create test-jar, which is used by the log4j-core-its module required to fix log4j2 build on travis (see https://github.com/apache/logging-log4j2/pull/102) You can merge this pul

[GitHub] logging-log4j2 issue #102: replace oraclejdk7 with openjdk7 on travis

2017-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/logging-log4j2/pull/102 log4j-core-its fail to build because: >logging.log4j:log4j-core-its:jar:2.9-SNAPSHOT: Could not find artifact org.apache.logging.log4j:log4j-server:jar:tests:2.9-SNAPSHOT in

[jira] [Comment Edited] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

2017-07-31 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107669#comment-16107669 ] Ralph Goers edited comment on LOG4J2-1990 at 7/31/17 5:41 PM: -

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

2017-07-31 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107669#comment-16107669 ] Ralph Goers commented on LOG4J2-1990: - I have a use case with Audit logging where I o

[GitHub] logging-log4j2 pull request #102: replace oraclejdk7 with openjdk7 on travis

2017-07-31 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/logging-log4j2/pull/102 replace oraclejdk7 with openjdk7 on travis I'm giving it another try (now that the scala api stuff was moved). You can merge this pull request into a Git repository by running:

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

2017-07-31 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107548#comment-16107548 ] Matt Sicker commented on LOG4J2-1990: - That just seems like too vague of a setting, t

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

2017-07-31 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107501#comment-16107501 ] Gary Gregory commented on LOG4J2-1990: -- I think log4j2.ignoreExceptions might be mor

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

2017-07-31 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107476#comment-16107476 ] Matt Sicker commented on LOG4J2-1990: - The only configuration available (even with my

[GitHub] logging-log4j2 issue #93: modification to resolver to discover jar assests w...

2017-07-31 Thread ta924
Github user ta924 commented on the issue: https://github.com/apache/logging-log4j2/pull/93 After some additional research I found that an internal library was excluding all log4jplugins.dat files to ensure that only specific packages were scanned. This was accomplished by a custom cl

Re: Left to do for 2.9 release

2017-07-31 Thread Mikael Ståldal
Me too. I think it's to much bureaucratic overhead with a new repo. On 2017-07-30 22:48, Gary Gregory wrote: * "Prepare release of logging-log4j-tools repo (if we want to do that)": For my buck, I'd prefer to see the log4j-server module in the main repo. Gary

Re: log4-server JmsServer is broken

2017-07-31 Thread Mikael Ståldal
Nice. On 2017-07-30 17:18, Gary Gregory wrote: I'll take a look... On Jul 30, 2017 06:07, "Mikael Ståldal" > wrote: The JmsServer in log4j-server is currently broken, since the JmsManager in log4j-core has changed. Someone needs to fix this, and I don't r