[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102808#comment-16102808 ] Gary Gregory commented on LOG4J2-1990: -- OK, let's leave Map and Collection checking

Build failed in Jenkins: Log4j 2.x #2939

See Changes: [ggregory] [LOG4J2-1991] Refactor SimpleMessage to be concise and clear. Closes -- [...truncated 4.61 MB...] [JENKINS] Archiving

[jira] [Closed] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kenneth mcfarland closed LOG4J2-1991. - > Refactor SimpleMessage to use ternary statements where appropriate > --

[jira] [Resolved] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1991. -- Resolution: Fixed In git master, please verify and close. Thank you. > Refactor SimpleMessage

[jira] [Commented] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102761#comment-16102761 ] ASF GitHub Bot commented on LOG4J2-1991: Github user asfgit closed the pull reque

[jira] [Commented] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102760#comment-16102760 ] ASF subversion and git services commented on LOG4J2-1991: - Commit

[GitHub] logging-log4j2 pull request #100: LOG4J2-1991 - Refactor SimpleMessage to be...

Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j2/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102716#comment-16102716 ] kenneth mcfarland commented on LOG4J2-1991: --- Link to PR : https://github.com/ap

[jira] [Commented] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

[ https://issues.apache.org/jira/browse/LOG4J2-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102713#comment-16102713 ] ASF GitHub Bot commented on LOG4J2-1991: GitHub user kpm1985 opened a pull reques

[GitHub] logging-log4j2 pull request #100: LOG4J2-1991 - Refactor SimpleMessage to be...

GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/100 LOG4J2-1991 - Refactor SimpleMessage to be concise and clear with the use of approp… …riate ternary statements. All test have been ran from the log4j2-api root and pass with build succe

[jira] [Created] (LOG4J2-1991) Refactor SimpleMessage to use ternary statements where appropriate

kenneth mcfarland created LOG4J2-1991: - Summary: Refactor SimpleMessage to use ternary statements where appropriate Key: LOG4J2-1991 URL: https://issues.apache.org/jira/browse/LOG4J2-1991 Project:

Jenkins build became unstable: Log4j 2.x #2938

See

[jira] [Closed] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kenneth mcfarland closed LOG4J2-1989. - All good in the hood. > Javadoc for AbstractTriggeringPolicy is hard to understand > ---

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102639#comment-16102639 ] Remko Popma commented on LOG4J2-1990: - Gary, to answer your question, I would prefer

[jira] [Commented] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102631#comment-16102631 ] ASF GitHub Bot commented on LOG4J2-1989: Github user asfgit closed the pull reque

[jira] [Commented] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102630#comment-16102630 ] ASF subversion and git services commented on LOG4J2-1989: - Commit

[jira] [Resolved] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1989. -- Resolution: Fixed Fix Version/s: 2.9 In git master, please verify and close. > Javadoc

[GitHub] logging-log4j2 pull request #99: LOG4J2-1989 - Clarify javadoc for AbstractT...

Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j2/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102629#comment-16102629 ] ASF subversion and git services commented on LOG4J2-1989: - Commit

[jira] [Commented] (LOG4J2-1988) java.util.ConcurrentModificationException with AsyncLogger?

[ https://issues.apache.org/jira/browse/LOG4J2-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102599#comment-16102599 ] Gary Gregory commented on LOG4J2-1988: -- Can you test the patch? I also wonder if we

[jira] [Commented] (LOG4J2-1988) java.util.ConcurrentModificationException with AsyncLogger?

[ https://issues.apache.org/jira/browse/LOG4J2-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102597#comment-16102597 ] Gary Gregory commented on LOG4J2-1988: -- Not that a {{Map}} is not a {{Collection}} w

[jira] [Comment Edited] (LOG4J2-1988) java.util.ConcurrentModificationException with AsyncLogger?

[ https://issues.apache.org/jira/browse/LOG4J2-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102597#comment-16102597 ] Gary Gregory edited comment on LOG4J2-1988 at 7/27/17 2:00 AM:

[jira] [Commented] (LOG4J2-1988) java.util.ConcurrentModificationException with AsyncLogger?

[ https://issues.apache.org/jira/browse/LOG4J2-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102549#comment-16102549 ] Remko Popma commented on LOG4J2-1988: - Interestingly, a similar issue was reported re

Jenkins build is back to stable : Log4j 2.x #2935

See

[log4j] PropertiesRewritePolicy.rewrite(LogEvent) uses deprecated code.

Should: org.apache.logging.log4j.core.appender.rewrite.PropertiesRewritePolicy.rewrite(LogEvent) be reimplemented using a StringMap since the API it uses now is deprecated? Gary

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102367#comment-16102367 ] Gary Gregory commented on LOG4J2-1990: -- Did you just close the issue? If so, please

[jira] [Updated] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1990: - Attachment: LOG4J2-1990.patch > ConcurrentModificationException logging a parameter of type Map

[jira] [Reopened] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened LOG4J2-1990: -- > ConcurrentModificationException logging a parameter of type Map > --

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102364#comment-16102364 ] Gary Gregory commented on LOG4J2-1990: -- Also, instead of checking for {{Collection}}

[jira] [Commented] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102362#comment-16102362 ] Gary Gregory commented on LOG4J2-1990: -- Either JMeter needs to use an implementation

Re: [01/12] logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

Great! Gary On Jul 26, 2017 12:58, "Mikael Ståldal" wrote: > I have fixed it, see latest master branch: > > https://github.com/apache/logging-log4j2/blob/master/log4j- > core/src/main/java/org/apache/logging/log4j/core/parser/Abst > ractJacksonLogEventParser.java > > > On 2017-07-26 21:44, Gary

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

I have updated the socket server in the log4-server module in the log4j-tools repo to use 2.9-SNAPSHOT, and to use this. While doing so, I discovered that the log4j-server module (JmsServer class) used JmsManager in log4j-core, which you have changed in a non-backwards compatible way. I did so

Jenkins build is still unstable: Log4j 2.x #2934

See

Re: [01/12] logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

I have fixed it, see latest master branch: https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/main/java/org/apache/logging/log4j/core/parser/AbstractJacksonLogEventParser.java On 2017-07-26 21:44, Gary Gregory wrote: -1 to throwing RuntimeException, again. See the LOG4J2-1986-

[jira] [Closed] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

[ https://issues.apache.org/jira/browse/LOG4J2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Mouawad closed LOG4J2-1990. Resolution: Invalid > ConcurrentModificationException logging a parameter of type Map > --

[jira] [Created] (LOG4J2-1990) ConcurrentModificationException logging a parameter of type Map

Philippe Mouawad created LOG4J2-1990: Summary: ConcurrentModificationException logging a parameter of type Map Key: LOG4J2-1990 URL: https://issues.apache.org/jira/browse/LOG4J2-1990 Project: Log

Re: [01/12] logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

-1 to throwing RuntimeException, again. See the LOG4J2-1986-b branch for a solution. Gary On Jul 26, 2017 12:34, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/master b464da6b0 -> 9576bbfe2 > > > LOG4J2-1986 Public API for parsing the output from > JsonLayout/XmlLayout/

[jira] [Resolved] (LOG4J2-1986) Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

[ https://issues.apache.org/jira/browse/LOG4J2-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal resolved LOG4J2-1986. Resolution: Fixed Fix Version/s: 2.9 In Git master, please verify and close [~huxi].

[jira] [Commented] (LOG4J2-1987) Log4J JUL Bridge and RMI Security Manager causes access denied ("java.util.logging.LoggingPermission" "control")

[ https://issues.apache.org/jira/browse/LOG4J2-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102161#comment-16102161 ] ASF subversion and git services commented on LOG4J2-1987: - Commit

[jira] [Commented] (LOG4J2-1977) Consider the StringBuilder's capacity instead of content length when trimming

[ https://issues.apache.org/jira/browse/LOG4J2-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102162#comment-16102162 ] ASF subversion and git services commented on LOG4J2-1977: - Commit

Re: Lilith and Log4j 2

That would make sense. On 2017-07-26 19:51, Jörn Huxhorn wrote: Isn’t this supposed to also use 0-byte terminated events in the future? Because in that case it would make sense to change from String to byte[] processing. On 26. July 2017 at 17:49:07, Mikael Ståldal (mi...@apache.org) wrote: T

Jenkins build became unstable: Log4j 2.x #2933

See

[GitHub] logging-log4j2 pull request #59: Fix rollover to work when filePattern conta...

Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j2/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Lilith and Log4j 2

Isn’t this supposed to also use 0-byte terminated events in the future? Because in that case it would make sense to change from String to byte[] processing. On 26. July 2017 at 17:49:07, Mikael Ståldal (mi...@apache.org) wrote: > They just need the String version: > > https://github.com/apache/

Re: Lilith and Log4j 2

They just need the String version: https://github.com/apache/logging-log4j-tools/blob/master/log4j-server/src/main/java/org/apache/logging/log4j/server/InputStreamLogEventBridge.java#L100 On 2017-07-26 17:40, Gary Gregory wrote: What do our XML and JSON server need? Let's make sure we handle t

[GitHub] logging-log4j2 issue #93: modification to resolver to discover jar assests w...

Github user ta924 commented on the issue: https://github.com/apache/logging-log4j2/pull/93 Sorry Gary had some things pop up on the work front that have eaten up most of my time. I will get you an example as soon as things free up. --- If your project is set up for it, you can reply

Re: Lilith and Log4j 2

What do our XML and JSON server need? Let's make sure we handle those use cases. Gary On Jul 26, 2017 05:30, "Jörn Huxhorn" wrote: > +1 > > > On 26. July 2017 at 13:29:27, Mikael Ståldal (mi...@apache.org) wrote: > > Maybe I should remove both the Reader and the InputStream versions, > > since

Re: Lilith and Log4j 2

+1 On 26. July 2017 at 13:29:27, Mikael Ståldal (mi...@apache.org) wrote: > Maybe I should remove both the Reader and the InputStream versions, > since they cannot parse multiple log events from a stream, and are thus > not very useful. > > On 2017-07-26 10:34, Jörn Huxhorn wrote: > > It would

Re: Lilith and Log4j 2

That’s what I meant with too lenient. It was probably a bad idea. Might make more sense to think about which Mixins, if any, should get a @JsonIgnoreProperties(ignoreUnknown=true) annotation… but that is unrelated to the general parsing API. I kind of derailed the topic because this really does

Re: Lilith and Log4j 2

A slightly related question, what should the parser do about missing properties? Currently it is so lenient that it will successfully parse an empty JSON object "{}" and just assign null (or other default values) to all fields. On 2017-07-25 23:24, Jörn Huxhorn wrote: Hey Mikael, sorry for

Re: Lilith and Log4j 2

Maybe I should remove both the Reader and the InputStream versions, since they cannot parse multiple log events from a stream, and are thus not very useful. On 2017-07-26 10:34, Jörn Huxhorn wrote: It would maybe be a good idea to get rid of the Reader method altogether since it mainly introd

[jira] [Updated] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kenneth mcfarland updated LOG4J2-1989: -- This is more than a typo so this is my first time filing a JIRA. Here is the PR I filed th

[jira] [Commented] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

[ https://issues.apache.org/jira/browse/LOG4J2-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101546#comment-16101546 ] ASF GitHub Bot commented on LOG4J2-1989: GitHub user kpm1985 opened a pull reques

[GitHub] logging-log4j2 pull request #99: LOG4J2-1989 - Clarify javadoc for AbstractT...

GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/99 LOG4J2-1989 - Clarify javadoc for AbstractTriggeringPolicy.java This clarifies the javadoc for AbstractTriggeringPolicy. You can merge this pull request into a Git repository by running:

[jira] [Created] (LOG4J2-1989) Javadoc for AbstractTriggeringPolicy is hard to understand

kenneth mcfarland created LOG4J2-1989: - Summary: Javadoc for AbstractTriggeringPolicy is hard to understand Key: LOG4J2-1989 URL: https://issues.apache.org/jira/browse/LOG4J2-1989 Project: Log4j 2

Re: Lilith and Log4j 2

Whoops... yes, of course. false. m) I'd use the byte[] method in Lilith. It would maybe be a good idea to get rid of the Reader method altogether since it mainly introduces an unnecessary point of failure if the Reader is using an encoding other than UTF-8. Using a FileReader would be an examp

[jira] [Commented] (LOG4J2-1002) PatternLayout is missing a new line for Exceptions with the short option

[ https://issues.apache.org/jira/browse/LOG4J2-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101316#comment-16101316 ] Nicola Isotta commented on LOG4J2-1002: --- Any update on this? > PatternLayout is mi

Re: Lilith and Log4j 2

I guess you mean: this.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); Out of curiosity, which of the methods would you use? Reading InputStream, Reader, String or byte[] ? On 2017-07-25 23:24, Jörn Huxhorn wrote: Hey Mikael, sorry for the slow response time. GMail tho