Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Matt Sicker
But some of the methods threw a runtime exception which could just be another type of parse exception if differentiation is necessary. On 23 July 2017 at 21:16, Gary Gregory wrote: > On Jul 23, 2017 19:10, "Matt Sicker" wrote: > > Nothing wrong with making more custom exceptions. > > > This new

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
On Jul 23, 2017 19:10, "Matt Sicker" wrote: Nothing wrong with making more custom exceptions. This new package already defines a new exception ParseException. Gary On 23 July 2017 at 16:46, Gary Gregory wrote: > Also, I'd like to see this used from our socket server classes to make sure >

Re: [VOTE] Release Log4j Scala API version 11.0 RC2

2017-07-23 Thread Matt Sicker
Away from computer at the moment, but yes, I'll be taking care of this as soon as possible. On 23 July 2017 at 18:54, Gary Gregory wrote: > I did not see a VOTE RESULT message. I'm sure Matt will get to it. > > Gary > > On Sat, Jul 22, 2017 at 2:14 PM, Ralph Goers > wrote: > > > Is this a vote

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Matt Sicker
Nothing wrong with making more custom exceptions. On 23 July 2017 at 16:46, Gary Gregory wrote: > Also, I'd like to see this used from our socket server classes to make sure > it fits nicely with that use case. > > Gary > > On Sun, Jul 23, 2017 at 1:05 PM, Gary Gregory > wrote: > > > OK, but Ru

Re: Log4J2 user guide

2017-07-23 Thread kenneth mcfarland
If this is it then, its just silly things like the bullet formatting consistency on page 2 (not roman numeral, the actual page 2). I just figured if I was reading through it I might as well clean up what I find as I go like the commenting

Re: Log4J2 user guide

2017-07-23 Thread Ralph Goers
The link to the pdf is on the main log4j 2 web page. The pdf is generated from the same source used to generate the html pages and we rarely review the pdf to see that things have extended beyond the page borders, so it wouldn’t be surprising to see those kinds of errors. The only changes in th

Re: Log4J2 user guide

2017-07-23 Thread kenneth mcfarland
The reason I ask is because there are multiple versions showing up on Google and the version I downloaded and have been reading is for 2.8 (I believe) with some prominent formatting errors. As I have been getting up to speed I have been contributing simple fixes for documentation and the like, and

Re: [VOTE] Release Log4j Scala API version 11.0 RC2

2017-07-23 Thread Gary Gregory
I did not see a VOTE RESULT message. I'm sure Matt will get to it. Gary On Sat, Jul 22, 2017 at 2:14 PM, Ralph Goers wrote: > Is this a vote thread or a discussion thread? Was there a vote result? > > Ralph > > > On Jul 22, 2017, at 12:56 PM, Matt Sicker wrote: > > > > Yup, that's the plan. I

Re: Log4J2 user guide

2017-07-23 Thread Gary Gregory
Good question, I do not see it on the site. You might have to build it from sources but I do not see instructions in our BUILDING.md file on how to use maven-pdf-plugin. Gary On Sun, Jul 23, 2017 at 4:04 PM, kenneth mcfarland < kennethpmcfarl...@gmail.com> wrote: > Can somebody point me at the n

Log4J2 user guide

2017-07-23 Thread kenneth mcfarland
Can somebody point me at the newest version of the log4j2 user guide PDF file?

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
Also, I'd like to see this used from our socket server classes to make sure it fits nicely with that use case. Gary On Sun, Jul 23, 2017 at 1:05 PM, Gary Gregory wrote: > OK, but RuntimeException should still never be thrown here... > > Gary > > On Sun, Jul 23, 2017 at 1:02 PM, Mikael Ståldal

Re: [Log4j] includeNullDelimiter

2017-07-23 Thread Gary Gregory
Don't bait me Mr. Swift! :-) Gary On Sat, Jul 22, 2017 at 12:54 PM, Matt Sicker wrote: > I usually stick to big endian encoding while on the JVM thanks to > ByteBuffer making it easy. If you write your own byte buffer style class, > then it doesn't really matter which endianness you choose as y

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
OK, but RuntimeException should still never be thrown here... Gary On Sun, Jul 23, 2017 at 1:02 PM, Mikael Ståldal wrote: > But that's not quite correct. I want to distinguish between unable to > parse due to malformed input (ParseException), and unable to read from > input (IOException). When

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Mikael Ståldal
But that's not quite correct. I want to distinguish between unable to parse due to malformed input (ParseException), and unable to read from input (IOException). When reading from String or byte[], unable to read from input shouldn't happen. On 2017-07-23 21:50, Gary Gregory wrote: You alread

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
For my money, I also do not see the point of declaring IOException in the API and then changing one kind of IOException to a ParseException. I would just rewrite the class like this: class AbstractJacksonLogEventParser implements TextLogEventParser { final ObjectReader objectReader; Abst

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
Hi, Parse exception is missing its serialVersionUID Gary On Sat, Jul 22, 2017 at 1:48 PM, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1986 [created] c4814a873 > > > LOG4J2-1986 Public API for parsing the output from > JsonLayout/XmlLayout/YamlLayout > into a

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Gary Gregory
You already declare and throw ParseException, so I would use ParseException. Gary On Sun, Jul 23, 2017 at 11:25 AM, Mikael Ståldal wrote: > Do you have another suggestion? > > > On 2017-07-23 05:01, Gary Gregory wrote: > >> -1 to throw new RuntimeException(e) >> >> Gary >> >> On Jul 22, 2017

Re: logging-log4j2 git commit: LOG4J2-1986 Public API for parsing the output from JsonLayout/XmlLayout/YamlLayout into a LogEvent

2017-07-23 Thread Mikael Ståldal
Do you have another suggestion? On 2017-07-23 05:01, Gary Gregory wrote: -1 to throw new RuntimeException(e) Gary On Jul 22, 2017 13:48, wrote: Repository: logging-log4j2 Updated Branches: refs/heads/LOG4J2-1986 [created] c4814a873 LOG4J2-1986 Public API for parsing the output from Json

[jira] [Commented] (LOGCXX-491) SizeBasedRollingTest cases fail when defining LOG4CXX_MULTI_PROCESS

2017-07-23 Thread Sean P. Miller (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097732#comment-16097732 ] Sean P. Miller commented on LOGCXX-491: --- I use the following configuration, which wo

[jira] [Commented] (LOGCXX-491) SizeBasedRollingTest cases fail when defining LOG4CXX_MULTI_PROCESS

2017-07-23 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097723#comment-16097723 ] Thorsten Schöning commented on LOGCXX-491: -- Do you use size based rolling in prod

[jira] [Commented] (LOGCXX-491) SizeBasedRollingTest cases fail when defining LOG4CXX_MULTI_PROCESS

2017-07-23 Thread Sean P. Miller (JIRA)
[ https://issues.apache.org/jira/browse/LOGCXX-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097718#comment-16097718 ] Sean P. Miller commented on LOGCXX-491: --- I use this feature in production on a very

[jira] [Comment Edited] (LOGCXX-491) SizeBasedRollingTest cases fail when defining LOG4CXX_MULTI_PROCESS

2017-07-23 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097691#comment-16097691 ] Thorsten Schöning edited comment on LOGCXX-491 at 7/23/17 3:43 PM: -

[jira] [Commented] (LOGCXX-491) SizeBasedRollingTest cases fail when defining LOG4CXX_MULTI_PROCESS

2017-07-23 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097691#comment-16097691 ] Thorsten Schöning commented on LOGCXX-491: -- Do you need this feature or just test

Re: [log4cxx] Release process releated questions

2017-07-23 Thread Thorsten Schöning
Guten Tag Robert Middleton, am Samstag, 22. Juli 2017 um 23:44 schrieben Sie: > I tried to verify with: gpg --verify apache-log4cxx-0.11.0.tar.gz.asc > apache-log4cxx-0.11.0.tar.gz > but gpg couldn't find the public key - do I need to import a special key at > all? That depends on GPG I guess, is

Re: [jira] [Comment Edited] (LOG4J2-1921) Getting ClassCastException while getting LoggerContext

2017-07-23 Thread Ralph Goers
> On Jul 23, 2017, at 12:34 AM, Gary Gregory wrote: > > We definitively got side tracked on this VOTE thread… > This isn’t the vote thread. I believe you replied to the wrong email. Ralph

Re: [jira] [Comment Edited] (LOG4J2-1921) Getting ClassCastException while getting LoggerContext

2017-07-23 Thread Gary Gregory
We definitively got side tracked on this VOTE thread... Gary On Sat, Jul 22, 2017 at 11:13 PM, Ajitha (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/LOG4J2-1921?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=16097523#comment-16097523