Re: logging-log4net git commit: (doc) Fix name of class LogicalThreadContext

2017-06-28 Thread Stefan Bodewig
Argh, I pushed this to the wrong branch (master instead of develop) by habit. Sorry Stefan

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

2017-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/logging-log4net/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] logging-log4net issue #11: (doc) Fix name of class LogicalThreadContext

2017-06-28 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/logging-log4net/pull/11 merged, many thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

2017-06-28 Thread MarcelGosselin
GitHub user MarcelGosselin opened a pull request: https://github.com/apache/logging-log4net/pull/11 (doc) Fix name of class LogicalThreadContext Fix name of class LogicalThreadContext in Scopes section, words were reversed. You can merge this pull request into a Git repository by r

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067614#comment-16067614 ] Gary Gregory commented on LOG4J2-1950: -- The test has JUnit Assume's to only run on J

Re: logging-log4j2 git commit: [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback from jira. Closes #89. - item 2: Better log at configuration step if file attribute view are defined

2017-06-28 Thread Gary Gregory
You are correct. I was going to add it later but it got mixed up in this commit. I just disabled it. Thank you for noticing! Gary On Wed, Jun 28, 2017 at 9:47 AM, Matt Sicker wrote: > That JMS stuff doesn't look like it belongs here? > > On 27 June 2017 at 13:12, wrote: > > > Repository: logg

[jira] [Commented] (LOG4J2-1934) JMS Appender does not know how to recover from a broken connection

2017-06-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067595#comment-16067595 ] ASF subversion and git services commented on LOG4J2-1934: - Commit

[jira] [Comment Edited] (LOG4J2-1611) Improve performance of ThreadContextDataInjector.ForDefaultThreadContextMap

2017-06-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15519381#comment-15519381 ] Remko Popma edited comment on LOG4J2-1611 at 6/29/17 1:39 AM: -

Re: Starting and restarting managers

2017-06-28 Thread Matt Sicker
This topic makes me think some sort of CircuitBreakerAppender may be useful as an analogue to FailoverAppender. Instead of permanently failing over to the backup appenders, this appender would eventually switch back to the primary appender when it's safely back up. Supporting a full open/half open/

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Gary Gregory
Brilliant! :-) Gary On Wed, Jun 28, 2017 at 10:09 AM, Matt Sicker wrote: > Oh, I missed the context line. It's part of the tag already. > > On 28 June 2017 at 12:02, Mikael Ståldal wrote: > > > I just did that, didn't I? > > > > > > > > On 2017-06-28 18:57, Gary Gregory wrote: > > > >> On Jun

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Matt Sicker
Oh, I missed the context line. It's part of the tag already. On 28 June 2017 at 12:02, Mikael Ståldal wrote: > I just did that, didn't I? > > > > On 2017-06-28 18:57, Gary Gregory wrote: > >> On Jun 28, 2017 08:54, "Matt Sicker" wrote: >> >> You can add a @deprecated javadoc tag to specify that

[jira] [Updated] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1958: --- Description: Due to inherent security weakness of Java object serialization, see https://www

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Mikael Ståldal
I just did that, didn't I? On 2017-06-28 18:57, Gary Gregory wrote: On Jun 28, 2017 08:54, "Matt Sicker" wrote: You can add a @deprecated javadoc tag to specify that which makes it more prominent in the javadocs. +1 Gary On 28 June 2017 at 08:50, wrote: Repository: logging-log4j2 Upda

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Gary Gregory
On Jun 28, 2017 08:54, "Matt Sicker" wrote: You can add a @deprecated javadoc tag to specify that which makes it more prominent in the javadocs. +1 Gary On 28 June 2017 at 08:50, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd > > >

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066847#comment-16066847 ] Matt Sicker commented on LOG4J2-1958: - Said status logger message might want to inclu

Re: logging-log4j2 git commit: [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback from jira. Closes #89. - item 2: Better log at configuration step if file attribute view are defined

2017-06-28 Thread Matt Sicker
That JMS stuff doesn't look like it belongs here? On 27 June 2017 at 13:12, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 93afa566c -> a5a95886b > > > [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback > from jira. Closes #89. > - item 2: Better

[jira] [Commented] (LOG4J2-928) Lock-free synchronous sub-microsecond appender

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066829#comment-16066829 ] ASF GitHub Bot commented on LOG4J2-928: --- Github user jvz commented on a diff in the

[GitHub] logging-log4j2 pull request #87: [LOG4J2-928] Mostly wait-free MemoryMappedF...

2017-06-28 Thread jvz
Github user jvz commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/87#discussion_r124592044 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ThreadHints.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache So

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Matt Sicker
You can add a @deprecated javadoc tag to specify that which makes it more prominent in the javadocs. On 28 June 2017 at 08:50, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd > > > LOG4J2-1958 Specify version when SerializedLayout is depr

[jira] [Resolved] (LOG4J2-1959) Disable DTD processing in XML configuration files

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal resolved LOG4J2-1959. Resolution: Fixed In Git master. > Disable DTD processing in XML configuration files > ---

[jira] [Created] (LOG4J2-1959) Disable DTD processing in XML configuration files

2017-06-28 Thread JIRA
Mikael Ståldal created LOG4J2-1959: -- Summary: Disable DTD processing in XML configuration files Key: LOG4J2-1959 URL: https://issues.apache.org/jira/browse/LOG4J2-1959 Project: Log4j 2 Issue

Re: [1/2] logging-log4j2 git commit: LOG4J2-1958 Deprecate SerializedLayout and remove it as default

2017-06-28 Thread Remko Popma
In the manual pages, can we mention that in previous versions the default was SerializedLayout, but as of log4j-2.9 users need to explicitly specify a layout since there is no default? I think it is important to document the log4j version when this change took place. On Wed, Jun 28, 2017 at 9:52 P

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066491#comment-16066491 ] Mikael Ståldal commented on LOG4J2-1950: Then something else might be wrong. Thos

[jira] [Commented] (LOG4J2-1949) On failover from JDBC appender, contents of buffer are not written to failover appender

2017-06-28 Thread Chris Slater (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066483#comment-16066483 ] Chris Slater commented on LOG4J2-1949: -- Yes. I can create a patch. > On failove

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread Pierrick HYMBERT (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066485#comment-16066485 ] Pierrick HYMBERT commented on LOG4J2-1950: -- The docker VM is configured {{FROM o

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066477#comment-16066477 ] ASF GitHub Bot commented on LOG4J2-1725: GitHub user phymbert opened a pull reque

[GitHub] logging-log4j2 pull request #90: [LOG4J2-1725] RollingFileAppender's filePat...

2017-06-28 Thread phymbert
GitHub user phymbert opened a pull request: https://github.com/apache/logging-log4j2/pull/90 [LOG4J2-1725] RollingFileAppender's filePattern not reloaded Reproduced and fixed, allow to update PatternProcessor of the reused manager if configuration changed. You can merge this pull r

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066445#comment-16066445 ] Mikael Ståldal commented on LOG4J2-1950: {quote}SecureSocketAppenderSocketOptions

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066437#comment-16066437 ] Mikael Ståldal commented on LOG4J2-1958: See Git branch LOG4J2-1958. > Deprecate

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066411#comment-16066411 ] Mikael Ståldal commented on LOG4J2-1958: Yes, that could be a good idea. > Depre

[jira] [Updated] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly

2017-06-28 Thread Pierrick HYMBERT (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierrick HYMBERT updated LOG4J2-1086: - Attachment: LOG4J2-1086.Test.patch Hello [~ralph.go...@dslextreme.com] and team, I am no

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-28 Thread Pierrick HYMBERT (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066120#comment-16066120 ] Pierrick HYMBERT commented on LOG4J2-1699: -- OK for me, thank you all! Dear [~ddi