[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060438#comment-16060438 ] ASF GitHub Bot commented on LOG4J2-1699: Github user phymbert closed the pull req

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060437#comment-16060437 ] ASF GitHub Bot commented on LOG4J2-1699: Github user phymbert commented on the is

[GitHub] logging-log4j2 issue #83: [LOG4J2-1699] Refactor PosixFileAttributeViewActio...

2017-06-22 Thread phymbert
Github user phymbert commented on the issue: https://github.com/apache/logging-log4j2/pull/83 Merged in 9d32793b12e2fe9b7a77519e59f5027942db4917 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] logging-log4j2 pull request #83: [LOG4J2-1699] Refactor PosixFileAttributeVi...

2017-06-22 Thread phymbert
Github user phymbert closed the pull request at: https://github.com/apache/logging-log4j2/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Jenkins build is back to stable : Log4j 2.x #2819

2017-06-22 Thread Apache Jenkins Server
See

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060406#comment-16060406 ] Gary Gregory commented on LOG4J2-1699: -- [~phymbert]: Thank you for that last PR. No

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060402#comment-16060402 ] ASF subversion and git services commented on LOG4J2-1699: - Commit

[jira] [Created] (LOG4J2-1952) log4j doesn't find log4j2.yaml

2017-06-22 Thread Todd Sewell (JIRA)
Todd Sewell created LOG4J2-1952: --- Summary: log4j doesn't find log4j2.yaml Key: LOG4J2-1952 URL: https://issues.apache.org/jira/browse/LOG4J2-1952 Project: Log4j 2 Issue Type: Bug Comp

[GitHub] logging-log4net issue #6: Try and trap a date when looking for the next back...

2017-06-22 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/6 This patch provides the same functionality as #9 does. Since this patch affects the current behavior and I have a bad feeling about changing the behavior of the rolling file appender, I see a

Re: PR or Patch File for external contribution ?

2017-06-22 Thread Mikael Ståldal
We would however like to have a JIRA issue even when you open a GitHub PR, and have them linked together. On 2017-06-22 21:38, Gary Gregory wrote: A JIRA is also a place for discussion but GitHub is much nicer since you can comment on actual lines of code. Sweet feature. Gary On Thu, Jun 22,

[GitHub] logging-log4net issue #10: Improve the performance of looking up the windows...

2017-06-22 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/10 The patch basically wraps the invocation to WindowsIdentity.GetCurrent() into a provider that refreshes the identity in the background once every 15 seconds. Please discuss! --- If your pr

[GitHub] logging-log4net pull request #10: Improve the performance of looking up the ...

2017-06-22 Thread dpsenner
GitHub user dpsenner opened a pull request: https://github.com/apache/logging-log4net/pull/10 Improve the performance of looking up the windows identity This reopens the old pull request 45. You can merge this pull request into a Git repository by running: $ git pull https://gi

[GitHub] logging-log4net issue #9: Allow for dates that aren't necessarily in the yyy...

2017-06-22 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/9 With respect to #6 this patch is cleaner. Since this affects the current behavior and I have a bad feeling about changing the behavior of the rolling file appender, I see a unit test as a req

[GitHub] logging-log4net pull request #9: Allow for dates that aren't necessarily in ...

2017-06-22 Thread dpsenner
GitHub user dpsenner opened a pull request: https://github.com/apache/logging-log4net/pull/9 Allow for dates that aren't necessarily in the -MM-dd format. This reopens the old pull request 43. Please note that the old pull request 29 (reopened as #6) provides the same functional

[GitHub] logging-log4net issue #8: Implemented changes for the Util/AppenderAttachedI...

2017-06-22 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/8 This is again a rather large patch that requires an ICLA from the original author Harry Martyrossian. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] logging-log4net pull request #8: Implemented changes for the Util/AppenderAt...

2017-06-22 Thread dpsenner
GitHub user dpsenner opened a pull request: https://github.com/apache/logging-log4net/pull/8 Implemented changes for the Util/AppenderAttachedImpl.cs class for calling log4net appenders in parallel using .NET Task Parallel Library This reopens the old pull request 40 and provides a

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

2017-06-22 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/7 We need an ICLA from the author Peter Jas since this is a rather large change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] logging-log4net pull request #7: Add log4net asp.net extension

2017-06-22 Thread dpsenner
GitHub user dpsenner opened a pull request: https://github.com/apache/logging-log4net/pull/7 Add log4net asp.net extension This reopens the old pull request 32 and provides a place for discussion. It would be nice to have some feedback from the author of the original patch. You can

[GitHub] logging-log4net pull request #6: Try and trap a date when looking for the ne...

2017-06-22 Thread dpsenner
GitHub user dpsenner opened a pull request: https://github.com/apache/logging-log4net/pull/6 Try and trap a date when looking for the next backup number. This reopens the old pull request 29 and provides a place for discussion. Please note that the old pull request 43 provides the s

Re: [log4net] jenkins

2017-06-22 Thread Dominik Psenner
*bump* I would still like to update the build configuration on builds.apache.org so that log4net is built with pipelines against multiple branches and pull requests. Would you please grant me the karma to work on this? Cheers, Dominik 2017-06-13 0:14 GMT+02:00 Dominik Psenner : > Hi Ralph, > >

Re: PR or Patch File for external contribution ?

2017-06-22 Thread Gary Gregory
A JIRA is also a place for discussion but GitHub is much nicer since you can comment on actual lines of code. Sweet feature. Gary On Thu, Jun 22, 2017 at 12:22 PM, Dominik Psenner wrote: > And pull requests provide a place for discussions and code review. > > 2017-06-22 18:15 GMT+02:00 Matt Sic

[jira] [Commented] (LOG4NET-82) RollingFileAppender: Cannot RollFile ... Source does not exist

2017-06-22 Thread Dominik Psenner (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059886#comment-16059886 ] Dominik Psenner commented on LOG4NET-82: Please note that this is not actually an

Re: PR or Patch File for external contribution ?

2017-06-22 Thread Dominik Psenner
And pull requests provide a place for discussions and code review. 2017-06-22 18:15 GMT+02:00 Matt Sicker : > Pull requests are definitely easier to merge, plus you get a nicer online > diff tool that way. Patch files are fine, too, but only if you prefer > submitting them that way. > > On 22 Jun

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059771#comment-16059771 ] ASF GitHub Bot commented on LOG4J2-1950: Github user phymbert commented on the is

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

2017-06-22 Thread phymbert
Github user phymbert commented on the issue: https://github.com/apache/logging-log4j2/pull/84 I tried to minimise changes, I would prefer to install mvn as a package rather to freeze the version. I may do it tom if you are fine with it. --- If your project is set up for it, you can

[jira] [Updated] (LOG4J2-1949) On failover from JDBC appender, contents of buffer are not written to failover appender

2017-06-22 Thread Chris Slater (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Slater updated LOG4J2-1949: - Affects Version/s: 2.8.2 > On failover from JDBC appender, contents of buffer are not written to

[jira] [Updated] (LOG4J2-1951) On shutdown, JDBC appender does not write buffered log messages to failover appender if database is unavailable

2017-06-22 Thread Chris Slater (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Slater updated LOG4J2-1951: - Description: With the following sample config: {code:xml}

[jira] [Created] (LOG4J2-1951) On shutdown, JDBC appender does not write buffered log messages to failover appender if database is unavailable

2017-06-22 Thread Chris Slater (JIRA)
Chris Slater created LOG4J2-1951: Summary: On shutdown, JDBC appender does not write buffered log messages to failover appender if database is unavailable Key: LOG4J2-1951 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059640#comment-16059640 ] ASF GitHub Bot commented on LOG4J2-1950: Github user jvz commented on the issue:

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

2017-06-22 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/logging-log4j2/pull/84 Can certainly be updated for that since it's not installed via apt-get. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059639#comment-16059639 ] ASF GitHub Bot commented on LOG4J2-1950: Github user garydgregory commented on th

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

2017-06-22 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/84 Curious, why not Maven 3.5.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Updated] (LOG4J2-1949) On failover from JDBC appender, contents of buffer are not written to failover appender

2017-06-22 Thread Chris Slater (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Slater updated LOG4J2-1949: - Description: With the following sample config: {code:xml}

Re: PR or Patch File for external contribution ?

2017-06-22 Thread Matt Sicker
Pull requests are definitely easier to merge, plus you get a nicer online diff tool that way. Patch files are fine, too, but only if you prefer submitting them that way. On 22 June 2017 at 10:53, Gary Gregory wrote: > It is really up to you, what ever works for you. > > Gary > > On Jun 22, 2017

Re: PR or Patch File for external contribution ?

2017-06-22 Thread Gary Gregory
It is really up to you, what ever works for you. Gary On Jun 22, 2017 03:38, "Pierrick HYMBERT" wrote: > Hi, > > What is the most appropriate way for log4j team to handle external > contribution ? GitHub Pull Request or Patch file ? > > I used to attach patch in jira from my local branch, but t

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059547#comment-16059547 ] ASF GitHub Bot commented on LOG4J2-1950: GitHub user phymbert opened a pull reque

[GitHub] logging-log4j2 pull request #84: [LOG4J2-1950] Fix docker build with jdk9 re...

2017-06-22 Thread phymbert
GitHub user phymbert opened a pull request: https://github.com/apache/logging-log4j2/pull/84 [LOG4J2-1950] Fix docker build with jdk9 requirements Revert docker image base from openjdk:7-alpine to openjdk:7-jdk (debian) since yet alpine does not include jdk9. Install jdk9 and sp

[jira] [Created] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-22 Thread Pierrick HYMBERT (JIRA)
Pierrick HYMBERT created LOG4J2-1950: Summary: Docker build broken with log4j-api-java9 Key: LOG4J2-1950 URL: https://issues.apache.org/jira/browse/LOG4J2-1950 Project: Log4j 2 Issue Type

[jira] [Comment Edited] (LOG4NET-82) RollingFileAppender: Cannot RollFile ... Source does not exist

2017-06-22 Thread Ayush Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059275#comment-16059275 ] Ayush Agrawal edited comment on LOG4NET-82 at 6/22/17 12:33 PM:

[jira] [Commented] (LOG4NET-82) RollingFileAppender: Cannot RollFile ... Source does not exist

2017-06-22 Thread Ayush Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059275#comment-16059275 ] Ayush Agrawal commented on LOG4NET-82: -- I am having a console application where I am

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread Pierrick HYMBERT (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059272#comment-16059272 ] Pierrick HYMBERT commented on LOG4J2-1699: -- Hello, Well :-) I did it this way -

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059266#comment-16059266 ] ASF GitHub Bot commented on LOG4J2-1699: GitHub user phymbert opened a pull reque

[GitHub] logging-log4j2 pull request #83: [LOG4J2-1699] Refactor PosixFileAttributeVi...

2017-06-22 Thread phymbert
GitHub user phymbert opened a pull request: https://github.com/apache/logging-log4j2/pull/83 [LOG4J2-1699] Refactor PosixFileAttributeViewAction with Builder. Fix posix tests on jenkins. Refactor PosixFileAttributeViewAction with Builder rather than method factory. Split posix test

PR or Patch File for external contribution ?

2017-06-22 Thread Pierrick HYMBERT
Hi, What is the most appropriate way for log4j team to handle external contribution ? GitHub Pull Request or Patch file ? I used to attach patch in jira from my local branch, but then I tried tutorial from Gary [1] and see that it is possible to ask for PR directly from github forked repo [2] and