[GitHub] logging-log4j2 issue #78: Fix writeObject in FormattedMessage.

2017-05-16 Thread remkop
Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/78 The serialVersionUID can remain unchanged if * the new version of the software can deserialize "old" serialized objects (backwards compatible) * the "old" version of the software can des

[GitHub] logging-log4j2 issue #78: Fix writeObject in FormattedMessage.

2017-05-16 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/logging-log4j2/pull/78 Do you have java 9 installed? Make sure to follow the [setup instructions](https://github.com/apache/logging-log4j2/blob/master/BUILDING.md). As for the travis check, the thing below the comments.

[GitHub] logging-log4j2 issue #78: Fix writeObject in FormattedMessage.

2017-05-16 Thread bsokolovu
Github user bsokolovu commented on the issue: https://github.com/apache/logging-log4j2/pull/78 I don't see reasons to change serialVersionUID. It's not new version of entity. I'd like to add unit test but I can't build even `master` branch because of some odd error on execution `j

[GitHub] logging-log4j2 issue #78: Fix writeObject in FormattedMessage.

2017-05-16 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/logging-log4j2/pull/78 Code looks good. Can you add a unit test? Also, does the serialVersionUID need to be changed, or is this a safe serialization change? --- If your project is set up for it, you can reply to this e

[GitHub] logging-log4j2 pull request #78: Fix writeObject in FormattedMessage.

2017-05-16 Thread bsokolovu
GitHub user bsokolovu opened a pull request: https://github.com/apache/logging-log4j2/pull/78 Fix writeObject in FormattedMessage. To pass `FormattedMessage` completely we should pass string values from `argArray` together with `argArray.length`. For now there is such bug: on `

[jira] [Closed] (LOG4J2-1909) nano second in log4j

2017-05-16 Thread tsimba kely (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tsimba kely closed LOG4J2-1909. --- Resolution: Fixed > nano second in log4j > > > Key: LOG4J2-1909