Re: Java 9 modules

Sounds pretty good to me, thanks for getting clarification. I haven't looked at the JPMS API yet, but by the sounds of it, we may be able to use it for some interesting plugin things as it is. On 9 May 2017 at 23:34, Ralph Goers wrote: > I got further clarification on the jigsaw dev list. > http

Re: Java 9 modules

I got further clarification on the jigsaw dev list. http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-May/012562.html . I am still waiting for an answer about the impact to our plugin system, but I am pretty sure it wi

Re: [OT] Java 9 module vote results

Even though they weren't part of the vote, my local JUG has the same opinion as the London JUG. We have some OSGi developers there as well (e.g., from Felix). The sounds of some of those votes are "it's almost ready, and it might be good enough now, but what was submitted is not what exists at thi

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003880#comment-16003880 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on the is

Re: [OT] Java 9 module vote results

Right, they have 30 days to adjust. Gary On Tue, May 9, 2017 at 5:53 PM, Ralph Goers wrote: > My understanding is that this is still an interim ballot. I believe the > final vote is supposed to happen around June 1. Still 9 for and 13 against > is mighty “interesting”. > > Ralph > > > On May 9,

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop I did that for log4j-core only. Yes, it passes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

Re: Java 9 modules

I’m not sure what that means. I may try to refactor log4j-api to be a Multi-Release jar so that the IDEs have less of an issue. However, once the next Java 9 JDK is released I believe whatever the issue with the tests was that Gary found will be fixed, so he should just be able to use Java 9

Re: [OT] Java 9 module vote results

My understanding is that this is still an interim ballot. I believe the final vote is supposed to happen around June 1. Still 9 for and 13 against is mighty “interesting”. Ralph > On May 9, 2017, at 12:59 PM, Gary Gregory wrote: > > FYI: https://jcp.org/en/jsr/results?id=5959 > > Notice the

Re: Java 9 modules

So similar to the OSGi bundle loading strategy, for Java 9, we'll need a layer loading strategy? On 9 May 2017 at 11:36, Ralph Goers wrote: > As I understand it, what you are saying is possible but Log4j doesn’t > currently need to load these dependencies dynamically. We dynamically load > our p

[OT] Java 9 module vote results

FYI: https://jcp.org/en/jsr/results?id=5959 Notice the comments in the text box. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

Re: Java 9 modules

As I understand it, what you are saying is possible but Log4j doesn’t currently need to load these dependencies dynamically. We dynamically load our plugins, but the plugins we are talking about are provided by Log4j. These plugins use a third party jar and these are hard-wired dependencies. Thi

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002951#comment-16002951 ] ASF GitHub Bot commented on LOG4J2-1874: Github user remkop commented on the issu

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 Do all tests pass when you run `mvn clean install` on your machine? (may take ~20 minutes) On Wednesday, May 10, 2017 12:34 AM, Roman Leventov wrote: @remkop this

Re: Java 9 modules

Hello all! I have been lurking on the list for a while, as a user of both log4j and log4cxx. This Java 9 module situation greatly interests me. About the circularity problem, isn't it the case that loading modules at runtime will solve the circularity problem? As far as I understand the new sys

Re: Java 9 modules

While it may sound reasonable, it is not. Matt’s point about LoggerFinder and our support of NoSQL appenders and the like is proof that there are valid reasons for circularities. We are just lucky that Jackson and Disruptor don’t seem to do logging or we would have circularities there too. BTW

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002881#comment-16002881 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on the is

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop this test used to depend on specific line numbers in this test. Made it more generic. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002872#comment-16002872 ] ASF GitHub Bot commented on LOG4J2-1874: Github user remkop commented on the issu

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @leventov Thanks for the quick turnaround. Today I only had time to check that the tests pass, but I ran `mvn clean install` twice and both times it failed here: ``` [ERROR] Tests

Re: Java 9 modules

On May 9, 2017 12:18 AM, "Remko Popma" wrote: (Shameless plug) Every java main() method deserves http://picocli.info > On May 9, 2017, at 15:35, Gary Gregory wrote: > > Hi All, > > On Mon, May 8, 2017 at 10:46 PM, Ralph Goers > wrote: > >> So I keep reading up on Java modules and the more I

[GitHub] logging-log4j2 pull request #71: [LOG4J2-1874] Add ByteBufferDestionation.wr...

Github user leventov commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/71#discussion_r115515373 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java --- @@ -32,9 +32,14 @@ public class StringBui

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002845#comment-16002845 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on a diff

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002831#comment-16002831 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on a diff

[GitHub] logging-log4j2 pull request #71: [LOG4J2-1874] Add ByteBufferDestionation.wr...

Github user leventov commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/71#discussion_r115512718 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java --- @@ -32,9 +32,14 @@ public class StringBui

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002782#comment-16002782 ] ASF GitHub Bot commented on LOG4J2-1874: Github user jvz commented on a diff in t

[GitHub] logging-log4j2 pull request #71: [LOG4J2-1874] Add ByteBufferDestionation.wr...

Github user jvz commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/71#discussion_r115505200 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java --- @@ -32,9 +32,14 @@ public class StringBuilderE

Re: Java 9 modules

This raises a question: how do you add a provider for System.Logger? Any implementation will need to use java.base, but java.base contains System.Logger, so you get a cycle right off the bat. Same goes for pretty much every class in Java. On 9 May 2017 at 03:04, Mikael Ståldal wrote: > We alread

Re: Build Failure (ClassNotFoundException: j.x.b.JAXBException)

You have to run Maven with Java 7, and then setup toolchains.xml to allow it to use Java 9 when needed. See https://github.com/apache/logging-log4j2/blob/master/BUILDING.md On Tue, May 9, 2017 at 10:22 AM, Volkan Yazıcı wrote: > I cannot succeed in compiling the master. > Can anyone help me to f

Build Failure (ClassNotFoundException: j.x.b.JAXBException)

I cannot succeed in compiling the master. Can anyone help me to figure out what is going on and how can I fix it? I am trying to work on the Redis appender and JsonLayout#additionalFields. Though I need to admit it is *really* difficult to work, since I could make neither IntelliJ IDEA, nor mvnw to

Re: Java 9 modules

We already have the circular case with KafkaAppender, the Kafka client library we use logs with SLF4J. On Tue, May 9, 2017 at 7:46 AM, Ralph Goers wrote: > So I keep reading up on Java modules and the more I do the more confused I > get about how this can ever work properly. > > 1. I am confuse

Re: Java 9 modules

Yes, although we could fully modularize the API right away. Ralph > On May 9, 2017, at 12:51 AM, Gary Gregory wrote: > >> On Tue, May 9, 2017 at 12:34 AM, Apache wrote: >> >> Technically you are considered modularized just by adding a manifest entry >> providing the module name. But all the p

Re: Java 9 modules

On Tue, May 9, 2017 at 12:34 AM, Apache wrote: > Technically you are considered modularized just by adding a manifest entry > providing the module name. But all the packages are exported. You cannot do > more than that until all your dependencies do at least that much. > So it's a two-step. Firs

Re: Java 9 modules

Technically you are considered modularized just by adding a manifest entry providing the module name. But all the packages are exported. You cannot do more than that until all your dependencies do at least that much. Ralph > On May 9, 2017, at 12:27 AM, Gary Gregory wrote: > >> On Tue, May 9,

Re: Java 9 modules

On Tue, May 9, 2017 at 12:24 AM, Apache wrote: > I read that previously but if Log4J implements modules I don't see how the > nodal appenders or flume appender can work. > > I also got a reply to my query about referencing dependencies that are not > yet modularized and the recommendation is to o

[jira] [Commented] (LOG4J2-1798) InterruptedException on RollingFileManager#rollover()

[ https://issues.apache.org/jira/browse/LOG4J2-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002211#comment-16002211 ] Gary Gregory commented on LOG4J2-1798: -- Hi Karel, Feel free to provide a patch if y

Re: Java 9 modules

I read that previously but if Log4J implements modules I don't see how the nodal appenders or flume appender can work. I also got a reply to my query about referencing dependencies that are not yet modularized and the recommendation is to only use the manifest entry and not have a module-info.j

[jira] [Commented] (LOG4J2-1798) InterruptedException on RollingFileManager#rollover()

[ https://issues.apache.org/jira/browse/LOG4J2-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002209#comment-16002209 ] Karel Cerman commented on LOG4J2-1798: -- Hello is there any information about fix for

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002210#comment-16002210 ] Gary Gregory commented on LOG4J2-1725: -- Karel, The best way to move an issue forwar

[jira] [Commented] (LOG4J2-864) RollingFile - bad naming of files within zipped archives

[ https://issues.apache.org/jira/browse/LOG4J2-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002208#comment-16002208 ] Karel Cerman commented on LOG4J2-864: - Hello is there any chance that this will be fi

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002204#comment-16002204 ] Karel Cerman commented on LOG4J2-1725: -- Hello, is there any possibility that this w

Re: Java 9 modules

(Shameless plug) Every java main() method deserves http://picocli.info > On May 9, 2017, at 15:35, Gary Gregory wrote: > > Hi All, > > On Mon, May 8, 2017 at 10:46 PM, Ralph Goers > wrote: > >> So I keep reading up on Java modules and the more I do the more confused I >> get about how this