Re: Java 9 modules

2017-05-08 Thread Gary Gregory
Hi All, On Mon, May 8, 2017 at 10:46 PM, Ralph Goers wrote: > So I keep reading up on Java modules and the more I do the more confused I > get about how this can ever work properly. > > 1. I am confused about how we are supposed to create a module and > reference something that is not yet a modu

Re: Java 9 modules

2017-05-08 Thread Ralph Goers
So I keep reading up on Java modules and the more I do the more confused I get about how this can ever work properly. 1. I am confused about how we are supposed to create a module and reference something that is not yet a module. As I understand it, it will either be an automatic module on the

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

2017-05-08 Thread leventov
Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop thanks for review. Replaced custom class in ThreadLocal with `Object[]`. Fixed a bug in `TextEncoderHelper`, `ThrowableProxyTest.testCircularSuppressedExceptions()` passes now. ---

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001999#comment-16001999 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on the is

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Gary Gregory
On Mon, May 8, 2017 at 6:40 PM, Matt Sicker wrote: > If OSGi is going to refuse to support multi-release jars, then I doubt > they're going to remain relevant over time as it's a rather important > feature for libraries. > Don't tell that to IBM... ;-) Gary > > On 8 May 2017 at 11:21, Ralph G

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Matt Sicker
If OSGi is going to refuse to support multi-release jars, then I doubt they're going to remain relevant over time as it's a rather important feature for libraries. On 8 May 2017 at 11:21, Ralph Goers wrote: > BTW - it may, or may not, be possible to run the full build with Java 9 > once the bug

Jenkins build is back to normal : Log4j 2.x #2772

2017-05-08 Thread Apache Jenkins Server
See

[jira] [Commented] (LOG4J2-1903) Update SLF4J from 1.7.24 to 1.7.25

2017-05-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001553#comment-16001553 ] ASF subversion and git services commented on LOG4J2-1903: - Commit

[jira] [Created] (LOG4J2-1903) Update SLF4J from 1.7.24 to 1.7.25

2017-05-08 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1903: Summary: Update SLF4J from 1.7.24 to 1.7.25 Key: LOG4J2-1903 URL: https://issues.apache.org/jira/browse/LOG4J2-1903 Project: Log4j 2 Issue Type: Improvement

[jira] [Closed] (LOG4J2-1903) Update SLF4J from 1.7.24 to 1.7.25

2017-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1903. Resolution: Fixed In Git master. > Update SLF4J from 1.7.24 to 1.7.25 > --

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Ralph Goers
BTW - it may, or may not, be possible to run the full build with Java 9 once the bug Gary found gets fixed - which should be in the next EA release. See http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-July/002414.html .

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Ralph Goers
mvn site should work, but only when run by itself under Java 9. That is how you run it for a release build anyway - all by itself. Ralph > On May 8, 2017, at 8:33 AM, Matt Sicker wrote: > > How exactly are we supposed to make a release then if "mvn site" doesn't > work? > > On 8 May 2017 at 1

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Matt Sicker
How exactly are we supposed to make a release then if "mvn site" doesn't work? On 8 May 2017 at 10:32, Ralph Goers wrote: > The issue is that Matt keeps changing the Jenkins job to do "mvn clean > install site” instead of “mvn clean install”. The job cannot run the site > plugin as that must be

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Ralph Goers
The issue is that Matt keeps changing the Jenkins job to do "mvn clean install site” instead of “mvn clean install”. The job cannot run the site plugin as that must be run in java 9. Ralph > On May 8, 2017, at 7:57 AM, Matt Sicker wrote: > > But the issue in the stack trace is that the javado

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000886#comment-16000886 ] Gary Gregory commented on LOG4J2-1359: -- Doing anything in Eclipse is currently near

Re: [Log4j] log4j-server

2017-05-08 Thread Gary Gregory
On May 8, 2017 8:00 AM, "Mikael Ståldal" wrote: This is another reason for multiple repos, different release cycles. But then I don't really see the point of a single "kitchen sink" log4j-plugins containing a lot of unrelated plugins. I guess you would want a different release cycle for each plu

Re: [Log4j] log4j-server

2017-05-08 Thread Mikael Ståldal
This is another reason for multiple repos, different release cycles. But then I don't really see the point of a single "kitchen sink" log4j-plugins containing a lot of unrelated plugins. I guess you would want a different release cycle for each plugin, wouldn't you? On Sun, May 7, 2017 at 8:07 PM

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000864#comment-16000864 ] Matt Sicker commented on LOG4J2-1359: - The only build hack I know of (which is irrita

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Matt Sicker
But the issue in the stack trace is that the javadoc plugin is being run by java 7 in log4j-api when it needs to be run as java 9. On 8 May 2017 at 09:57, Matt Sicker wrote: > I only just recently fixed the email address configured in Jenkins, so > there were probably several other failure messa

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Matt Sicker
I only just recently fixed the email address configured in Jenkins, so there were probably several other failure messages that bounced to log4j-dev@. On 8 May 2017 at 09:43, Mikael Ståldal wrote: > I don't understand why the Jenkins build suddenly starts failing. It cannot > possibly be due to m

Re: Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Mikael Ståldal
I don't understand why the Jenkins build suddenly starts failing. It cannot possibly be due to my change to BUILDING.md, can it? On Mon, May 8, 2017 at 4:03 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See redirect?page

Maven warning

2017-05-08 Thread Mikael Ståldal
We get this Maven warning (from Jenkins build 2770), what is it about? Executing Maven: -B -f /home/jenkins/jenkins-slave/workspace/Log4j 2.x/pom.xml -Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -t jenkins-toolchains.xml clean install [INFO] Scanning for projects...[WARNING

Re: Scala API and Java API in the manual

2017-05-08 Thread Matt Sicker
https://builds.apache.org/job/Log4j%202.x/site/ On 8 May 2017 at 08:46, Mikael Ståldal wrote: > Looks good. > > On Mon, May 8, 2017 at 3:45 PM, Mikael Ståldal > wrote: > > > Where do you get the snapshot site? > > > > On Sun, May 7, 2017 at 8:57 PM, Matt Sicker wrote: > > > >> Just re-enabled

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000837#comment-16000837 ] Mikael Ståldal commented on LOG4J2-1359: I don't use an IDE to build the project

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000799#comment-16000799 ] Volkan Yazıcı commented on LOG4J2-1359: --- May I ask how do other people work on the

Build failed in Jenkins: Log4j 2.x #2771

2017-05-08 Thread Apache Jenkins Server
See Changes: [mikael.staldal] Fix typo -- [...truncated 63.84 KB...] V extends Object declared in method forEach(BiConsumer) [WARNING]

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000767#comment-16000767 ] Ralph Goers commented on LOG4J2-1359: - I suppose that's true. I have never built Log4

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000763#comment-16000763 ] Mikael Ståldal commented on LOG4J2-1359: Those instructions only tell you how to

Re: Scala API and Java API in the manual

2017-05-08 Thread Mikael Ståldal
Looks good. On Mon, May 8, 2017 at 3:45 PM, Mikael Ståldal wrote: > Where do you get the snapshot site? > > On Sun, May 7, 2017 at 8:57 PM, Matt Sicker wrote: > >> Just re-enabled the "site" target in Jenkins so we can get a snapshot site >> available. Also fixed the email address for notificat

Re: Scala API and Java API in the manual

2017-05-08 Thread Mikael Ståldal
Where do you get the snapshot site? On Sun, May 7, 2017 at 8:57 PM, Matt Sicker wrote: > Just re-enabled the "site" target in Jenkins so we can get a snapshot site > available. Also fixed the email address for notifications as it was still > on the old mailing list, so we wouldn't get any notifi

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000740#comment-16000740 ] Ralph Goers commented on LOG4J2-1359: - Please see the instructions in src/site/markdo

Re: Log4j 2.x RedisAppender

2017-05-08 Thread Mikael Ståldal
I think this should go into a new maven module "log4j-redis" since it has a specific external dependency (Jedis). We will most likely split up the NoSQL module and we don't want to add anything new to it. "NoSQL" is not really a useful abstraction within the context of Log4j. On Sat, May 6, 2017

[jira] [Commented] (LOG4J2-1694) Allow to easily add fields with fixed values to JSON output

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000724#comment-16000724 ] Volkan Yazıcı commented on LOG4J2-1694: --- [~mikaelstaldal], I'm already working on i

[jira] [Commented] (LOG4J2-1694) Allow to easily add fields with fixed values to JSON output

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000722#comment-16000722 ] Mikael Ståldal commented on LOG4J2-1694: I was not aware of any such feature in J

[jira] [Commented] (LOG4J2-1359) Add support for Java 9 StackWalker API in ReflectionUtil

2017-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000610#comment-16000610 ] Volkan Yazıcı commented on LOG4J2-1359: --- Hey [~ralphgoers], since the source code v

[jira] [Commented] (LOG4PHP-227) Throw an exception while using %request and sending parameter key as array

2017-05-08 Thread sharif Uddin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000514#comment-16000514 ] sharif Uddin commented on LOG4PHP-227: -- I replaced line 62 of the file with if(is_

[jira] [Commented] (LOG4PHP-227) Throw an exception while using %request and sending parameter key as array

2017-05-08 Thread sharif Uddin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000505#comment-16000505 ] sharif Uddin commented on LOG4PHP-227: -- any update on this issue as I am having the