Re: ConfiguratonFileWatcher and co

2017-04-30 Thread Ralph Goers
If it already is monitoring files, no. You can just add your FileWatcher. If it is not then you need to cause the monitoring interval to be set to a non-zero value. Ralph > On Apr 30, 2017, at 2:45 PM, Gary Gregory wrote: > > Log4j is already up and going in my case. Do I need to reconfigure

Re: [Log4j] Plans for modularization

2017-04-30 Thread Gary Gregory
+1 to the split plan. A l'attaque! Gary On Apr 30, 2017 1:23 PM, "Matt Sicker" wrote: > Just to make sure this sounds reasonable, here's my idea for a roadmap: > > 2.9: separate out more modules (not necessarily into their own repo or > repos yet) so that log4j-core contains minimal dependencie

Re: ConfiguratonFileWatcher and co

2017-04-30 Thread Gary Gregory
Log4j is already up and going in my case. Do I need to reconfigure log4j? Gary On Apr 30, 2017 1:40 PM, "Ralph Goers" wrote: > A WatchManager is always present. You don’t want to create another one. It > just isn’t started if watchManager.getIntervalSeconds() returns zero. > All you really have

Re: [Log4j] Plans for modularization

2017-04-30 Thread Matt Sicker
That's why I'd like to separate the two goals. It's possible that the difference between log4j-core and a divided core+spi would be minimal in which case I'd change gears with the goal of stabilising a public plugin and configuration SPI. On 30 April 2017 at 15:41, Ralph Goers wrote: > I am fine

Re: [Log4j] Plans for modularization

2017-04-30 Thread Ralph Goers
I am fine with your goals for 2.9. I still have my doubts that separating out an spi can be done. Ralph > On Apr 30, 2017, at 1:23 PM, Matt Sicker wrote: > > Just to make sure this sounds reasonable, here's my idea for a roadmap: > > 2.9: separate out more modules (not necessarily into their

Re: ConfiguratonFileWatcher and co

2017-04-30 Thread Ralph Goers
A WatchManager is always present. You don’t want to create another one. It just isn’t started if watchManager.getIntervalSeconds() returns zero. All you really have to do is WatchManager manager = configuration.getWatchManager(); If (manager.getIntervalSeconds == 0) { manager.setIntervalSeco

Re: [Log4j] Plans for modularization

2017-04-30 Thread Matt Sicker
Just to make sure this sounds reasonable, here's my idea for a roadmap: 2.9: separate out more modules (not necessarily into their own repo or repos yet) so that log4j-core contains minimal dependencies. 2.10: log4j-core-spi or whatever the name, making it easier for other modules to release on th

Re: ConfiguratonFileWatcher and co

2017-04-30 Thread Gary Gregory
Cool. If Log4j is NOT set up to monitor it's config file or if I want a different monitor interface, I can just build a WatchManager with a ConfigurationScheduler? Gary On Sun, Apr 30, 2017 at 11:09 AM, Ralph Goers wrote: > It already is generic. All you have to do is get the WatchManager from

Re: ConfiguratonFileWatcher and co

2017-04-30 Thread Ralph Goers
It already is generic. All you have to do is get the WatchManager from the Configuration and then call watchFile passing the File and the FileWatcher. Ralph > On Apr 30, 2017, at 11:02 AM, Gary Gregory wrote: > > Hi, > > I was hoping I can reuse some of ConfiguratonFileWatcher and co to watch

ConfiguratonFileWatcher and co

2017-04-30 Thread Gary Gregory
Hi, I was hoping I can reuse some of ConfiguratonFileWatcher and co to watch my own files but I cannot ATM, which is understandable of course. I was considering making this code a little more generic so that any one could watch their files. Thoughts? Gary -- E-Mail: garydgreg...@gmail.com | g

Re: [Log4j] Plans for modularization

2017-04-30 Thread Matt Sicker
I doubt Google uses Git then. One of the main goals of separating repositories is to make release management easier so we can RERO more! Though part of the problem there is that for some reason, the release process requires running all the tests and whatnot at least 3 times or more. On 30 April 2

[jira] [Commented] (LOG4NET-556) Rolling file appender only recognises dates in yyyy-MM-dd format.

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990287#comment-15990287 ] ASF GitHub Bot commented on LOG4NET-556: Github user bodewig commented on the iss

Re: [Log4j] Plans for modularization

2017-04-30 Thread Gary Gregory
Maybe more than one repo isn't such a good idea? I hear Google uses a single repo for all their code... Gary On Apr 30, 2017 9:41 AM, "Matt Sicker" wrote: > I've noticed just with the Scala repo that integrating various repositories > into a single coherent website is not so easy anymore (and i

Re: [Log4j] Plans for modularization

2017-04-30 Thread Matt Sicker
I've noticed just with the Scala repo that integrating various repositories into a single coherent website is not so easy anymore (and it wasn't really all that easy in the first place). While it may be possible to manage each repository's website individually and use symlinks in the svn repo to ke